Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functional tests and first FT to check homepage #81

Closed
wants to merge 2 commits into from
Closed

Added functional tests and first FT to check homepage #81

wants to merge 2 commits into from

Conversation

talaniz
Copy link

@talaniz talaniz commented Sep 26, 2015

This change creates a base.py which contains the Functional Test class. Currently, the class subclasses the LiveServerTestCase class and has setUp and tearDown methods. test_finding_contributr_projects.py is not completely finished, and stops at an intentional failure with a reminder to finish the test. Currently, it only checks for Contributr in the browser title and on the home page. I'll be pushing for more test cases to get ahead of some of the view development and to see if we can create user stories for testing overall functionality during development and for regression testing after new features are introduced.

@coolharsh55
Copy link
Contributor

@talaniz So why a PR when the functionality isn't finished or when the tests are failing?

@talaniz
Copy link
Author

talaniz commented Sep 27, 2015

2 reasons:

  1. The test is technically in a passing state, the fail is expected &
    initiated as a reminder to continue working on the test.
  2. The format is established in case anyone wants to contribute to it. FT's
    will usually be added to when new functionality is introduced.

On Sep 27, 2015, at 12:17 AM, Harshvardhan Pandit [email protected]
wrote:

@talaniz https://github.com/talaniz So why a PR when the functionality
isn't finished or when the tests are failing?


Reply to this email directly or view it on GitHub
#81 (comment).

@coolharsh55
Copy link
Contributor

@talaniz why do you want an intentionally failing test to be included that will break the CI builds every time? If the functionality isn't finished, you should create an issue on it, or a branch, if more people are working on it.

@talaniz
Copy link
Author

talaniz commented Oct 2, 2015

The reason there is an intentional fail is a reminder to complete the functional test. These tests are not meant to be covered by Travis CI and at the moment, they should not be covered in Pytest either. This is for testing that the code meets the expected functionality and that new features don't break any existing features. I've added the @pytest.mark.xfail and I'm checking to make sure this won't break Travis CI before pushing again.

Ideally, we should really kill this pull request.

Expected failure should skip pytest and travis CI.
@talaniz
Copy link
Author

talaniz commented Oct 2, 2015

Closing this request. Too many issues with functional test against Travis CI. Will send another later.

@talaniz talaniz closed this Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants