Improve media method #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid mutating the contents of the lists from the instance returned from `super()`, and instead use addition, [the recommended method of combining Media classes](https://docs.djangoproject.com/en/2.2/topics/forms/media/#combining-media-objects).
|
Is this backwards compatible? (quick note - I'm not doing much Django currently and haven't done for a while. Feel free to bypass me for PRs) |
|
Sorry, this fell off my radar. Since the linked docs are for the (now) long-released Django version 2.2, I assume that this has been the preferred way to merge Media objects since then. And since 2.2 has long been out of upstream Django support, I'm not sure that reverse compatibility for pre-2.2 releases is as important as it once was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid mutating the contents of the lists from the instance returned from
super(), and instead use addition, the recommended method of combining Media classes.