caleb/fix/stringdata #417
Merged
caleb/fix/stringdata #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ir data pointers have a GC occurs
Xmader
reviewed
Aug 27, 2024
| } | ||
|
|
||
| JS::AutoCheckCannotGC nogc; | ||
| for (const JSStringProxy *jsStringProxy: jsStringProxies) { // char buffers may have moved, so we need to re-point our JSStringProxies |
There was a problem hiding this comment.
In symmetry to this, would a Python str object move its char buffers, and how to notify the JS land?
There was a problem hiding this comment.
Do you know if python string objects move their buffers? As far as I'm aware they never move
Xmader
previously approved these changes
Aug 27, 2024
Xmader
approved these changes
Aug 28, 2024
|
Between JS_SetGCCallback and JS::AddGCNurseryCollectionCallback(), we should cover all cases where a JS String can be moved. (per jonco from moz, he hacks on the GC) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pursuit of fixing #340, this PR fixes some issues with string object reference counts. We now decrement strings (as well as lists and objects) even if their refcount = 1, which we were not doing before due to potential crashes during python's finalization, but now we just check if python is finalizing and if so skip all the refcount managing.
This also more intelligently manages the reference counts of string objects depended upon by JSExternalStrings, which will now have exactly the same lifetime as the JSExternalString (unless some other thing is keeping it alive, of course) without leaking memory.
Finally, it adds a GC callback that re-points all of the JSStringProxy data pointers to their associated data, since they may have moved during a GC.