fix: properly handle the reference count when doing list.concat()

`PyList_SetItem` steals the reference, so we must increase the reference count by 1
Distributive-Network · Sep 24, 2024 · 0eeda35 · 0eeda35
1 parent 8e365a7
commit 0eeda35
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/PyListProxyHandler.cc b/src/PyListProxyHandler.cc
@@ -553,8 +553,11 @@ static bool array_concat(JSContext *cx, unsigned argc, JS::Value *vp) {
 
   PyObject *result = PyList_New(selfSize);
 
+  // Copy items to the new list
   for (Py_ssize_t index = 0; index < selfSize; index++) {
-    PyList_SetItem(result, index, PyList_GetItem(self, index));
+    PyObject *item = PyList_GetItem(self, index);
+    Py_INCREF(item); // `PyList_SetItem` steals the reference, so we must increase the reference count by 1
+    PyList_SetItem(result, index, item);
   }
 
   unsigned numArgs = args.length();