SOV-3497 move sovrynSwapsImpl to internal protocol module #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add unit test for new module
tjcloa
requested changes
Nov 28, 2023
tjcloa
reviewed
Nov 28, 2023
tjcloa
reviewed
Nov 28, 2023
|
pls either remove interface ISwapsImpl or update it if there is a way we can use it - remove internalSwap function and rename internalExpectedRate and internalExpectedReturn to swapsImplExpectedRate and swapsImplExpectedReturn respectively |
tjcloa
requested changes
Nov 30, 2023
| log(col.bgBlue("Protocol modules are deployed")); | ||
| log( | ||
| col.bgBlue( | ||
| "Prepare and run SIP function in sips.js to create the proposal with params:" |
There was a problem hiding this comment.
Suggested change
| "Prepare and run SIP function in sips.js to create the proposal with params:" | |
| "Prepare a SIP creation function in sipArgs.js and run hardhat task `sips:create` to create proposal replacing modules:" |
and print replacing modules names and their addresses
There was a problem hiding this comment.
updated in this commit
There was a problem hiding this comment.
and print replacing modules names and their addresses
tjcloa
approved these changes
Nov 30, 2023
| log(col.bgBlue("Protocol modules are deployed")); | ||
| log( | ||
| col.bgBlue( | ||
| "Prepare and run SIP function in sips.js to create the proposal with params:" |
There was a problem hiding this comment.
and print replacing modules names and their addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.