Block: ignore margin collapsing when computing static position of abspos items #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Nov 27, 2024
nicoburns
force-pushed
the
block-absolute-static-pos
branch
from
d042e4a to
b076100
Compare
|
Not sure if this is completely correct (suspect it's not), but pretty sure it's now an improvement on what we had. |
…pos items Signed-off-by: Nico Burns <[email protected]>
nicoburns
force-pushed
the
block-absolute-static-pos
branch
from
b076100 to
ace9ed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Context
Discovered through Blitz's new WPT test runner