Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hydration race condition #3240

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

ryo33
Copy link
Contributor

@ryo33 ryo33 commented Nov 19, 2024

Fixes #2926

I fixed the issue by removing Interpreter::mount_to_root because its implementation either does nothing or throws the type error, effectively making it dead code.

mount_to_root had passed Node instead of NodeId to appendChildren(id: NodeId, many: number).

@ryo33 ryo33 marked this pull request as ready for review November 19, 2024 07:23
@ryo33
Copy link
Contributor Author

ryo33 commented Nov 19, 2024

The removed code always fails if the interpreter stack is not empty and does nothing if it is empty, so I suspect the code was added unintendedly.

@jkelleyrtp
Copy link
Member

Good catch - rebuild was changed at some point to not require additional appendChildren

@jkelleyrtp jkelleyrtp merged commit e145774 into DioxusLabs:main Nov 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants