WGPU using child windows #3093
Closed
WGPU using child windows #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n order to not reinitialize everything but only the bits needed. Naming of variables and resources are wonky and not the greatest.
ealmloff
reviewed
Oct 24, 2024
…ks. the abstractions in place should be passed the bounds rect down into the desktopservice to resize as opposed to in the app impl instead of how they are rn.
|
Slightly more interesting example of how this could play out: https://github.com/vyeevani/dioxus_native_graphics |
Screen.Recording.2024-10-24.at.4.15.51.PM.mov |
jkelleyrtp
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Thanks for the PR!
A few things:
- this wgpu version is out of date (0.9 vs 0.12)
- Are we sure we need the resizing code?
- I think we don't need the lifetimes in the wgpu code (or add a 'static lifetime)
- Can we gate
wgpubehind awgpufeature on dioxus-examples so we don't end up compiling it? - cargo.lock needs to be resolved for merge conflicts.
Closed
|
I struggled to get merge conflicts fixed for this PR since the github CLI was checking out the wrong branch. I ended up fixing things in #3257 and adding you as a co-author so you get commit credits :) Thanks for the PR! |
|
Awesome! Sorry I hadn't been very active on this, got pulled into some other stuff. thank you for seeing it through :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change from the code perspective to allow child windows to be created and some fixes for using the transparency feature. However, the implications of this are pretty staggering as they allow for the use of other rendering toolboxes.
Tested on macOS.