fix: use_route should subscribe to changes to the route #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autarch
suggested changes
Jan 28, 2022
|
|
||
| router.subscribe_onchange(cx.scope_id()); | ||
|
|
||
| UseRouteInner { |
There was a problem hiding this comment.
I think calling this UseRouteInner is confusing when it's not contained in a UseRoute. Maybe the existing UseRoute needs to be renamed to Inner and this one should be UseRoute?
There was a problem hiding this comment.
Hmmmm maybe something like UseRouteListener since its only job is to be dropped when the component is unmounted?
jkelleyrtp
pushed a commit
that referenced
this pull request
Jan 31, 2025
…out it being a todo (#168) Using the `todo` macro causes a panic when this event is encountered. Noop is preferable in this case as it does not crash the application. This is especially annoying on platforms where `Ime::Enabled` event is sent upon application start even when the user is using a keyboard layout that does not need an IME support. There was added a "TODO" comment that informs about this feature being missing. Most IDEs and code editors have support/plugins/extensions to work with this type of comments and this type of comment is already used widely across the codebase. As such, the information about this feature not being implemented is not lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so the
use_routecommand subscribes the component to changes to the URL.