Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugfix for popup settings #10814

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

nuanyang233
Copy link
Collaborator

@nuanyang233 nuanyang233 commented Sep 21, 2023

Description

Closes #MF-5288 MF-5303 MF-5315 MF-5317 MF-5321 MF-5322 MF-5323 MF-5325 MF-5327 MF-5334 MF-5339 MF-5341 MF-5349

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@nuanyang233 nuanyang233 added this to the 2.23.0 milestone Sep 21, 2023
@nuanyang233 nuanyang233 force-pushed the fix/bugfix-for-popup-settings branch from 36d9363 to 18532dc Compare September 21, 2023 11:02
@guanbinrui guanbinrui merged commit c83fd31 into release/2.23.0 Sep 21, 2023
@guanbinrui guanbinrui deleted the fix/bugfix-for-popup-settings branch September 21, 2023 12:08
guanbinrui pushed a commit that referenced this pull request Sep 22, 2023
* fix: bugfix for popup settings

* fix: bugfix for phone verify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants