Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove useless page and hooks code #10793

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

nuanyang233
Copy link
Collaborator

@nuanyang233 nuanyang233 commented Sep 19, 2023

Description

Closes #10792

Remove dashboard wallets page code.

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@nuanyang233 nuanyang233 added this to the 2.23.0 milestone Sep 19, 2023
Copy link
Member

@Jack-Works Jack-Works left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you're deleting many files. Can you give a better title for this PR? If you're doing multiple things at once, please list all those things

@nuanyang233 nuanyang233 changed the title fix: recovery crash refactor: remove useless page and hooks code Sep 19, 2023
@nuanyang233
Copy link
Collaborator Author

I see you're deleting many files. Can you give a better title for this PR? If you're doing multiple things at once, please list all those things

Ok, I've done.

@guanbinrui guanbinrui merged commit f99a8f9 into release/2.23.0 Sep 19, 2023
@guanbinrui guanbinrui deleted the fix/recovery-crash branch September 19, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants