Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issues for first public outing of OBO #1

Closed
8 of 10 tasks
ColmMassey opened this issue Oct 15, 2021 · 20 comments
Closed
8 of 10 tasks

Minor issues for first public outing of OBO #1

ColmMassey opened this issue Oct 15, 2021 · 20 comments
Assignees
Labels
OBO Owned By Oxford

Comments

@ColmMassey
Copy link

ColmMassey commented Oct 15, 2021

@wu-lee
Copy link

wu-lee commented Nov 9, 2021

* Choose style of map tiles used

How do we choose? Or has someone at ObO chosen?

@wu-lee
Copy link

wu-lee commented Nov 9, 2021

I've added the covid-mutual-aid dataset, filtered with:

FILTER(REGEX(UCASE(?street), 'OX[0-9]{1,2}\\b'))

This attempts to limit the query to addresses which seem to have an oxford postcode, although the data does not have an explicit postcode field so it's a bit fuzzy, and may miss out some Oxford-located initiatives if they don't include a postcode.

@ColmMassey
Copy link
Author

You may have broken it in the process!

@wu-lee
Copy link

wu-lee commented Nov 9, 2021

Yes, I did, I rediscovered a limitation of sea-map which breaks it when deployed at a path other than top level (i.e. like /owned-by-oxford/) and my hack I worked around it with last time I deployed it. Attempting to fix it properly I ran out of time, and had to go. Going to make another attempt shortly.

@wu-lee
Copy link

wu-lee commented Nov 9, 2021

Ok, fixed that sea-map problem, so its back up again!

@ColmMassey
Copy link
Author

* Choose style of map tiles used

How do we choose? Or has someone at ObO chosen?

It's in their court. Not urgent for anyone, so we can leave it for now.

@wu-lee
Copy link

wu-lee commented Nov 11, 2021

Ok, I've added an open-data conversion for good-food-oxford (still manual currently), and added the dataset to the ObO site. It's deployed and should be visible.

I use the Location Id as the prirmary identifier, and merely capture (but ignore) the Organisation Id.

There's no usable description field, unfortunately.

@wu-lee
Copy link

wu-lee commented Nov 15, 2021

See #3, short postcode now being used for the directory.

@ColmMassey
Copy link
Author

See #3, short postcode now being used for the directory.

Great. Works well. Would it be hard to extend to also do very short? i.e. 3 digits?

@wu-lee
Copy link

wu-lee commented Nov 18, 2021

Would it be hard to extend to also do very short? i.e. 3 digits?

Not sure I understand exactly - isn't OX10 shorter than 3 digits? Or do you mean 3 characters? That would however conflate OX1 and OX10 to OX19, is that useful?

However, in general, this is a hard-wired alteration of the list of fields in the sea-map code - although not a major change, it is probably rather too specific in the general case and warrants being moved out to site-specific customisation rather than being core. (Which we can't do yet but I think we should.)

@wu-lee
Copy link

wu-lee commented Nov 18, 2021

* Having the panel closed when the map page loads.

I've set the defaultOpenSidebar option to false in the ObO map config. Unfortunately there's a bug which makes it open anyway. Fortunately, I think I fixed that (hopefully without introducing new sidebar opening bugs in less obvious cases). Anyway, it doesn't open by default now in ObO.

See also DigitalCommons/mykomap#131 (comment)

@wu-lee
Copy link

wu-lee commented Nov 18, 2021

* Put sensible text in the about/info box. (Needs unhardwiring the new internationalised about page

This may be nearly fixed as per DigitalCommons/mykomap#125 (comment) - but if not, some sensible text (plus translations?) is needed.

@ColmMassey
Copy link
Author

Would it be hard to extend to also do very short? i.e. 3 digits?

Not sure I understand exactly - isn't OX10 shorter than 3 digits? Or do you mean 3 characters? That would however conflate OX1 and OX10 to OX19, is that useful?

However, in general, this is a hard-wired alteration of the list of fields in the sea-map code - although not a major change, it is probably rather too specific in the general case and warrants being moved out to site-specific customisation rather than being core. (Which we can't do yet but I think we should.)

I have confused you. But independently you addressed my request and we can search for OX1, OX2

@ColmMassey
Copy link
Author

* Decide how we approach categorising the uncategorised?

Is this still relevant as we are now using postcodes?

@wu-lee
Copy link

wu-lee commented Nov 18, 2021

Is this still relevant as we are now using postcodes?

Suspect it isn't, if postcodes are sufficient.

@ColmMassey
Copy link
Author

We have made the decision to make 2 sea-map instances for the OBO project. The current one will remain for the planners and steering committee etc, and provide access to as much relevant info as possible. We now need a second one, which will be cleaner and be the one for public consumption. I'll create a new ticket for that one and specify what it needs there.
#8

@ColmMassey
Copy link
Author

We can keep this one open for the moment for any discussions on what still needs finishing on the non public map.

@ColmMassey ColmMassey added the OBO Owned By Oxford label Jan 26, 2022
@ColmMassey
Copy link
Author

@wu-lee can you swithch obo-public to use Primary Activity as the Directory filter?

@ColmMassey
Copy link
Author

@wu-lee can you swithch obo-public to use Primary Activity as the Directory filter?

Is there anything holding this back?

@wu-lee
Copy link

wu-lee commented Mar 1, 2022

Only that my focus was elsewhere. I've redeployed with the primary activity as directory filter just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OBO Owned By Oxford
Projects
None yet
Development

No branches or pull requests

2 participants