Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBO Filter and Search Improvements #22

Closed
4 tasks done
ColmDC opened this issue Jan 9, 2023 · 11 comments
Closed
4 tasks done

OBO Filter and Search Improvements #22

ColmDC opened this issue Jan 9, 2023 · 11 comments
Labels

Comments

@ColmDC
Copy link
Contributor

ColmDC commented Jan 9, 2023

The funded part of the OBO project finished at the end of 2022. The following Usabilty needs came from and end of year feedback session with OBO OP Team.

We need to break the following into Issues and see if we can scehdule them under other budgets, as they are likley to benefit more than just the OBO project/

Usability need 1: there are two categories of people who will visit the site,
represented by the "Type for map" field, who will primarily be interested in one
or other of these types of organisation.

  • Currently there's no way to distinguish these on the map, but we can include
    the "Type for map" field as a drop-down search filter as a first step.
  • To do this we need a name for it which will make sense to visiting users -
    Anna and Simon will try to come up with something.
  • This arrangement is still possibly a bit unintuitive, however. Users need to
    know the filter exists and go and set it.
  • As an alternative, Nick suggested we could publish two maps, each showing one
    of these two categories, with no filter then required if you have selected the
    right map.
  • Anna thought this might work better.
  • These distinct maps could be implemented as a later step, as slightly more
    work than adding the filter. Probably the original would stay, and show one
    category, and a new one added for the latter.

Usability need 2: the directory and the drop-down filters currently can only
filter by "primary activity". And then, even if an "activities" filter were
added, these work separately and are combined by intersection. This makes a
search amongst all organisations for membership of a given category (e.g.
"food") hard or impossible.

  • This need suggests we need to combine the "primary activity" and "activities"
    fields into one, multi-valued field.
  • We would then need to display this as the directory, and possibly as a filter
    too. These would permit the same filtering function, approximately, but in
    different ways.
  • However, mykomap does not currently support a multi-valued field as a filter,
  • And possibly not as the directory either (need to check this).
  • This would also need altering the Airtable columns, and therefore the data
    factory.
  • Some extra logic would also be needed in the data factory to combine "primary
    activities" and "activities" from the "external initiatives" table.
  • If not implemented, this work would need to be scheduled within DCC's other
    priorities

Usability need 3: the text search only searches by name, so if you search for
"food" you don't find all the food providers, just those with "food" in their name

  • Ideally this would search for the name and the activities too.
  • (Possibly also other fields? This wasn't discussed however.)
  • We can add the "primary activity"/"activities" fields to the search index.
  • However, we may need to check that mykomaps allows searching multiple-valued
    vocabulary fields (like activities)
  • If not implemented, this work would need to be scheduled within DCC's other
    priorities

Very Quick Items

  • Hide the database panel;
  • Omit "Relationship" field.
  • if we don't have time to add more filter options than Activities, let's exclude the filter from the search panel until there is more than 1 in there.
  • Can usabilty need 3 not be addressed with different config options? Can we not set primaryActivity as a search field?
@ColmDC ColmDC added the Epic label Jan 9, 2023
@ColmDC ColmDC changed the title OBO Usability Improvements OBO Filter and Search Improvements Jan 9, 2023
@ColmDC
Copy link
Contributor Author

ColmDC commented Jan 9, 2023

@wu-lee can you look at the 4 tick boxes at the bottom of the Epic description. Can you comment if you think they are trivial changes that can be made?

@wu-lee
Copy link

wu-lee commented Jan 10, 2023

Suggestion from meeting of 10/2/23

  • Preserve primary and secondary activities in the data in addition to the merged field
  • Show primary/secondary in the pop up dialogs and filter, but the unified activities in the directory
  • Add org structure as a search filter

@ColmDC
Copy link
Contributor Author

ColmDC commented Jan 10, 2023

THere is a bug in the search code, where text searches don't match with labels of fields that have been spefied to be searched in the config, or commandline.

@wu-lee
Copy link

wu-lee commented Jan 26, 2023

Itemising the various suggestions from here and from the summarising email to Anna/Colm (attached), excluding those already itemised above.

  • Anna/Simon provide us for a user-friendly name for "Type for map" field, then:
    • Include this field in the data-factory's output data
    • Show this field in the ObO map
    • add it to the drop-down filters
    • Given the above, later:
      • Publish two maps instead of a single one, each showing data with one or other of the "Type for map" fields
  • Switch ObO to v3 of MykoMap and use the custom field / sparql bypass support there (currently on a hacked sparql bypass branch of Mykomap for ObO)
  • Preserve primary and secondary activities in the data, but add a merged field combining them
  • Check that a vocab field can be used for the map directory panel ANSWER: no, if used, vocab IDs are shown
    • and implement if not
    • Check that multi-value field can be used for the map directory panel ANSWER: no, multiple values seem to be stringified into a single value
      • and implement if not
      • show the combined activities field in the directory.
  • Check that a vocab field can be included as a search filter ANSWER: no, the ID is indexed for search, not the value
    • and implement if not
  • Check that a multi-value field can be included as a search filter ANSWER: no, a multiple-value field seems to be omitted from the search filters even when configured to be included
    • and implement if not
    • Show primary/secondary activity in the pop up dialogs and as a search filter
    • Show organisational structure to the pop-up dialogs, and as a search filter
  • Check that a multi-value field can be included in the text search ANSWER: not properly, multiple values seem to be stringified into a single value, with a comma delimiter
    • and implement if not
    • Add the combined activities field to the text search
    • Add the organisational structure field to the text search

Note that not all of these are to be done immediately, but they're included here to clarify the jobs arising from this discussion and allow them to be prioritised. They may warrant becoming separate tickets.
Re: Map update questions - 2022-12-08 1042.txt

@ColmDC
Copy link
Contributor Author

ColmDC commented Feb 17, 2023

Taking a look at
https://dev.maps.solidarityeconomy.coop/temp/

Should a text search with the word spaces identify all the orgs with Community and Collective Spaces as an Activty?

@ColmDC
Copy link
Contributor Author

ColmDC commented Feb 17, 2023

Moving bugs you've already identified after completing the TypeScript port here...

  • clearfilters button doesn't
  • back buttons broken?
  • "clearFilter" phrase and other language things not set
  • setting filter then unsetting it doesn't work - until you set to another value?
  • Countries (on ICA not OBO) includes "All" and "Any"
  • clicking on initiatives in sidebar won't popup when they are grouped?
  • clicking on initiatives in sidebar won't dialog? (last two may have been fixed magically)

@ColmDC
Copy link
Contributor Author

ColmDC commented Feb 17, 2023

It is hard to test with these known bugs in place. Let's address these first before doing any more involved testing.

@ColmDC
Copy link
Contributor Author

ColmDC commented Mar 24, 2023

I have attached the 3 bugs to this Epic. Do you think that once they are addressed we will be able to close this Epic?

Do we have a clear idea how the Type for map (with better title) would be configured to support easy distinguishing between those types within the filer/directory setting (not markers/icons)?

@wu-lee
Copy link

wu-lee commented Mar 29, 2023

For ObO, I think we need a way to show localised field names. I don't think we have an issue for that however. Will create that.

Also, I need to check that the text search works on vocab fields.

@ColmDC
Copy link
Contributor Author

ColmDC commented Apr 26, 2023

Countries (on ICA not OBO) includes "All" and "Any"
This is not an OBO issue. Is it duplicated in another ticket?
Covered here I beleive DigitalCommons/mykomap#177

@ColmDC
Copy link
Contributor Author

ColmDC commented May 9, 2023

I feel we can close this Epic. We knonw that supporting adhoc vocads in the filters is needed to fully support this, but lets create a new epic when Zenhub allows us, to handle the next steps of improving the directory and search panels.

@ColmDC ColmDC closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants