Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-230 Use common panel to display search results and include # of co-ops filtered + further fixes #251

Merged
merged 15 commits into from
Jun 3, 2024
Merged

MM-230 Use common panel to display search results and include # of co-ops filtered + further fixes #251

merged 15 commits into from
Jun 3, 2024

Conversation

rogup
Copy link
Contributor

@rogup rogup commented Jun 3, 2024

Re-applies the changes in #246 which were lost from dev
And also fixes problems identified in the QA testing of #230, namely:

  1. The close button not working on the initiative info sidebar when in mobile mode
  2. The individual directory entries not appearing when some maps (e.g. ICA) are first loaded, probably due to a race condition
  3. The "Apply Filters" button doesn't make sense in mobile mode, and should say "Show Results"

rogup added 15 commits May 2, 2024 15:44
@rogup
Tidy up index.ts html scaffolding of the app
be006fb
@rogup
Add new strings
988f45a
@rogup
Add util methods for checking viewport width
46b7639
@rogup
Fix directory filter
bfa8150
@rogup
Expose currently selected initatives state from MapPresenter
3c51093
@rogup
Move code for displaying a) the initiatives list and b) initiative in…
6ba1504 
…fo sidebar from DirectorySidebarView to a) BaseSidebarView and b) SidebarView
@rogup
Add Apply Filters button and filter count to search panel UI, and rem…
c2a3e94 
…ove scrollable results section
@rogup
Refresh search results when sidebar is refreshed, and allow subclasse…
3ddbf07 
…s of BaseSidebarView to choose how much of the UI is refreshed, based on whether the panel changed
@rogup
Styling changes
5f921bd
@rogup
Ensure 'clear filters' clears all filters and doesn't just reset them…
d048384 
… to initial state
@rogup
Fix forward button behaviour and show results panel when moving throu…
94e6249 
…gh history
@rogup
Improve string for showing results on mobile
72ade1b
@rogup
Fix initiative info close button on mobile
f74bc66
@rogup
Ensure directory displays all categories after they are loaded
b3a9544
@rogup
Merge branch 'dev' into 230-initiative-filtering-ui
5747de6
@rogup rogup merged commit cd4db51 into dev Jun 3, 2024
1 check passed
@wu-lee wu-lee deleted the 230-initiative-filtering-ui branch July 1, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rogup