316 - SFG reload map on refresh #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d sessionStorage var exists
rogup
reviewed
Apr 29, 2024
rogup
reviewed
Apr 29, 2024
rogup
reviewed
Apr 29, 2024
|
@rogup, thanks the refactoring advice, all changes made. |
|
@ms0ur1s cool, looks good to merge :) |
Nice one, thanks man. |
ms0ur1s
deleted the
316-social-farms--gardens-spring-24-reload-map-on-refresh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #316
If a browser refresh is performed when a map is open, LX is reloaded with the default untitled map.
As suggested by @rogup, on opening a map the mapId is added to the browser's sessionStorage, and when browser tab is reloaded a check is run and if a mapId is present the requisite map is reloaded.
What should we test?