Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account notification email language #28

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

joomdonation
Copy link

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo
Copy link
Member

laoneo commented Mar 26, 2023

Thanks. I guess the method exists calls can be removed.

@laoneo
Copy link
Member

laoneo commented Mar 26, 2023

Why is this all of the sudden needed? All I did was changing $this->app to $this->getApplication(), so it basically should be the same as before.

@joomdonation
Copy link
Author

Thanks. I guess the method exists calls can be removed

The loadLanguage method is not available in all kind of applications, so it would be safe to leave it there. I can remove it if you want

Why is this all of the sudden needed? All I did was changing $this->app to $this->getApplication(), so it basically should be the same as before

It is not the same as before. Please look at https://github.com/joomla/joomla-cms/blob/4.3-dev/libraries/src/Plugin/CMSPlugin.php#L168 . Before, we did not pass application to plugin, so the language file is loaded base on global language. With application object passed to plugin, it will now load the language file to the application language, so there is a difference.

@laoneo laoneo merged commit 14ad2ab into Digital-Peak:provider/plugins/user Mar 26, 2023
@laoneo
Copy link
Member

laoneo commented Mar 26, 2023

Ok, thanks!

laoneo added a commit that referenced this pull request Mar 29, 2023
* Convert user plugins to service provider

* form path

* Update plugins/user/contactcreator/services/provider.php

Co-authored-by: heelc29 <[email protected]>

* Update plugins/user/joomla/services/provider.php

Co-authored-by: heelc29 <[email protected]>

* Update plugins/user/profile/services/provider.php

Co-authored-by: heelc29 <[email protected]>

* Update plugins/user/terms/services/provider.php

Co-authored-by: heelc29 <[email protected]>

* Update plugins/user/token/services/provider.php

Co-authored-by: heelc29 <[email protected]>

* Update plugins/user/joomla/src/Extension/Joomla.php

Co-authored-by: heelc29 <[email protected]>

* Update plugins/user/joomla/src/Extension/Joomla.php

Co-authored-by: heelc29 <[email protected]>

* revert debug

* private

* Fix account notification email language (#28)

* Update plugins/user/joomla/src/Extension/Joomla.php

Co-authored-by: heelc29 <[email protected]>

* minor change

---------

Co-authored-by: heelc29 <[email protected]>
Co-authored-by: Tuan Pham Ngoc <[email protected]>
@joomdonation joomdonation deleted the patch-1 branch February 24, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants