Always respond with status code 500, on errors

DigiByte-Core · Aug 3, 2020 · 1d4b6f8 · 1d4b6f8
1 parent 8efa13e
commit 1d4b6f8
Showing 1 changed file with 7 additions and 14 deletions.
diff --git a/lib/controllers/Controller.js b/lib/controllers/Controller.js
@@ -48,25 +48,18 @@ class Controller {
   }
 
   static sendError(response, error) {
-    const details = error.details || {};
-    let code;
-
-    if (error.code < 0) {
-      details.originalCode = error.code;
-      code = 500;
-    } else {
-      code = error.code;
-    }
-
     const errResponse = {
-      code: code,
+      code: error.code,
       message: error.error || error.message,
       retriable: error.retriable || false,
-      details: details,
+      details: error.details,
     };
 
-    response.status(errResponse.code);
-    response.json(errResponse);
+    const serialized = JSON.stringify(errResponse, null, 4);
+
+    response.status(500);
+    response.send(serialized);
+    response.end();
   }
 
   /**