Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update to the new package system #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cherbst
Copy link

@cherbst cherbst commented Nov 13, 2014

This commit should make it possible to publish this package to the new package servers

@cherbst cherbst force-pushed the meteor-1.0 branch 2 times, most recently from 5f20f28 to ed59336 Compare November 19, 2014 16:26
@cherbst
Copy link
Author

cherbst commented Nov 19, 2014

If you don't like to update and if you don't mind, I can fork the package and publish it under my name on atmosphere.

@cherbst cherbst force-pushed the meteor-1.0 branch 3 times, most recently from 50483f8 to 51388aa Compare November 19, 2014 21:18
@dandv
Copy link

dandv commented Nov 28, 2014

👍

@mitar
Copy link

mitar commented Jan 16, 2015

Does this even work in current Meteor? It seems yields are not allowed anymore on the server side. So queries inside autorun will probably not work anymore?

meteor/meteor#1868

@cherbst
Copy link
Author

cherbst commented Jan 16, 2015

Interesting. I am using this package in my app with meteor 1.0.2. And I have not experienced the issue described in the above bug report. I thought this is because this package uses a deps implementation that is supposed to work on the server.

@mitar
Copy link

mitar commented Jan 16, 2015

The package contains no tests. :-(

It is interesting that an example uses Meteor.users.findOne {_id: @userId}, {reactive: true}, but findOne is not defined in the code.

@cherbst: Does it work for you if you would do ...find().fetch() inside the reactivePublish?

@cherbst
Copy link
Author

cherbst commented Jan 16, 2015

Yes, having no tests is unfortunate:-( I think the code you are referring to overrides the methods defined in cursor. So no need to define findOne, which is a collection method. And yes, find().fetch() certainly works!

@cherbst
Copy link
Author

cherbst commented Jan 16, 2015

Sorry, now that I checked my code I see that I only ever use find().map(), no find().fetch(). But I think this is essentially the same.

@cherbst cherbst closed this Jan 16, 2015
@cherbst cherbst reopened this Jan 16, 2015
@mitar
Copy link

mitar commented Jan 16, 2015

I understand it now, the package above uses this other package to override Deps.autorun to work on the server.

@cherbst
Copy link
Author

cherbst commented Jan 18, 2015

@mitar would you consider forking this package and publishing it?

@mitar
Copy link

mitar commented Jan 18, 2015

I forked the server-autorun package. Now that we have autorun ion the server, I will probably integrate reactivity into my own database access packages:

@dandv
Copy link

dandv commented May 22, 2015

Is this package on Atmosphere? https://atmospherejs.com/?q=reactive+publish

@cherbst
Copy link
Author

cherbst commented May 22, 2015

All packages on Atmosphere are forks of this package. The most recent seem to be lepozepo:reactive-publish and my own: cherbst:reactive-publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants