App state #7
Merged
App state #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reducer/selectors and add to rootReducer
…ate messageBox with styling
…add Loading when appState is loading in barcodeScanner
… stack, start logout on homescreen
…ack around logout Text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this branch I created a redux store/appState to keep track of when the app should be loading and when to display a message if anything goes wrong (instead of the Alert's I had before).
I created a component MessageBox that will actually move the entire screen down whenever a message needs to be displayed, the message goes away with setTimeout after a few seconds.
By implementing this I could remove a lot of other code as well. Code that was for showing the alert's or deleting the message from store/labels etc. Making my code look a lot cleaner in the process.
I also added two gif's as logo, the same one on the login and register page and similar on the HomeScreen. Where I also added a logout button.