Feat/e2e testing #57
Feat/e2e testing #57
Conversation
|
@lucifercr07 could you please review this |
|
@lucifercr07 can you give approval for running workflow, because I think as we have not yet deployed api, E2E tests wont work, as we wont have running instance of api and ui on localhost in the pipeline Your thoughts on this? |
|
@lucifercr07 It seems pipeline is failing as we don't have server and client up and running |
|
@Sanketmundada I don't see any workflow getting triggered, please have a look. |
|
@lucifercr07 Will look into it, meanwhile could you please tell me whether we really should keep test:e2e in workflow or not, as it requires both ui and api to be up. If we have to keep then I'm wondering how we can do that? |
|
@KaviiSuri please add your inputs. |
|
IMO, we can do 2 things:
Id prefer the 2nd one since we only use resources when we need them. Regarding running them in workflows, i would rather not. I think we should make it triggered through the actions panel on github, and can even setup a daily test run using cron schedules |
playwright.config.ts
Outdated
| /* Opt out of parallel tests on CI. */ | ||
| workers: process.env.CI ? 1 : undefined, | ||
| /* Reporter to use. See https://playwright.dev/docs/test-reporters */ | ||
| reporter: 'html', |
There was a problem hiding this comment.
Lets also use GitHub reporter here
Issue: