feat: project init structure with basic layout #4
Conversation
|
@lucifercr07 hey please Let me know if NextJS / project structure changes are required. |
There was a problem hiding this comment.
@rishavvajpayee can you also update README.md with instructions around how to start and develop. You can refer to DiceDB doc to maintain parity.
|
@lucifercr07 updated the ReadME file with the required instructions |
There was a problem hiding this comment.
Please check getting error in build
Linting and checking validity of types ..Failed to compile.
./app/components/PlaygroundTerminal.tsx:6:46
Type error: Binding element 'output' implicitly has an 'any' type.
4 | import { Dice1 } from 'lucide-react';
5 |
> 6 | export default function PlaygroundTerminal({ output, command, setCommand, handleCommand }) {
| ^
7 | const terminalRef = useRef<HTMLDivElement>(null);
8 |
9 | useEffect(() => {
|
hey @lucifercr07 added the missing type checks. build is working now. Sorry didn't checked the run build command before pushing the PR. |
There was a problem hiding this comment.
Thanks @rishavvajpayee for contribution, we can get on a call if you want and iron out few changes suggested
src/components/Search/SearchBox.tsx
Outdated
| /> | ||
| </div> | ||
| </div> | ||
| <div className="space-y-2"> |
There was a problem hiding this comment.
Initially we don't need to set values, it can be empty.
src/components/CLI/CLI.tsx
Outdated
| ))} | ||
| </div> | ||
| <div className="flex items-center bg-gray-700 rounded px-2 mb-4"> |
There was a problem hiding this comment.
@rishavvajpayee shall we try to maintain similarity with redis-cli?
For reference:
src/components/CLI/CLI.tsx
Outdated
| <div className="flex items-center bg-gray-700 rounded px-2 mb-4"> | ||
| <Dice1 className="w-4 h-4 text-green-500 mr-2" /> | ||
| <span className="text-green-500">dice></span> |
There was a problem hiding this comment.
Let's just keep white text for now on blackbackground.
There was a problem hiding this comment.
hey i went ahead and tried to copy the UI of dicedb.io we can change the UI later on.
There was a problem hiding this comment.
LGTM, minor changes we'll require can be taken up in following PRs.
Thanks @rishavvajpayee for contributing.
changes: