Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: code refactor & improves #78

Merged
merged 16 commits into from
Oct 28, 2023
Merged

feat: code refactor & improves #78

merged 16 commits into from
Oct 28, 2023

Conversation

scffs
Copy link
Collaborator

@scffs scffs commented Oct 28, 2023 •
edited
Loading

В рамках PR:

  • Удален <CalendarRange />
  • Улучшена типизация
  • Убран ужас из enum Grade - он в целом удален и теперь используем стандартный из diary-shared, т.к. больше не нуждаеся с костыле
  • Мелкие улучшения по коду
  • Обновлены зависимости

scffs added 2 commits October 28, 2023 15:19
@scffs
remove CalendarRange.tsx
0b6f15e
@scffs
Merge branch 'main' into remove-calendar
19c9bb8 
# Conflicts:
#	src/components/UI/CalendarRange.tsx
#	src/views/Schedule.tsx
@scffs scffs self-assigned this Oct 28, 2023
@scffs scffs requested review from Zamelane and Kopchan October 28, 2023 08:29
@scffs scffs added the feature New feature or request label Oct 28, 2023
@scffs scffs changed the title feat: remove calendar feat: code refactor & improves Oct 28, 2023
@scffs scffs marked this pull request as ready for review October 28, 2023 18:00
@scffs scffs mentioned this pull request Oct 28, 2023
Closed
@scffs scffs merged commit 4598a73 into main Oct 28, 2023
@scffs scffs deleted the remove-calendar branch October 30, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zamelane Zamelane Zamelane approved these changes

@Kopchan Kopchan Awaiting requested review from Kopchan

Assignees

@scffs scffs

Labels
feature New feature or request
Projects
diary
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scffs @Zamelane