Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Python 3.8 #157

Merged
merged 1 commit into from
Jul 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions .github/workflows/code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,8 @@ jobs:
fail-fast: false
matrix:
os: ["ubuntu-latest"] # can add windows-latest, macos-latest
python: ["3.8", "3.9", "3.10"]
install: ["-e .[dev]"]
# Make one version be non-editable to test both paths of version code
include:
- os: "ubuntu-latest"
python: "3.8"
install: ".[dev]"
python: ["3.9", "3.10"]
install: [".[dev]", "-e .[dev]"]

runs-on: ${{ matrix.os }}
env:
Expand Down
2 changes: 1 addition & 1 deletion docs/developer/how-to/pin-requirements.rst
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ of the dependencies and sub-dependencies with pinned versions.
You can download any of these files by clicking on them. It is best to use
the one that ran with the lowest Python version as this is more likely to
be compatible with all the versions of Python in the test matrix.
i.e. ``requirements-test-ubuntu-latest-3.8.txt`` in this example.
i.e. ``requirements-test-ubuntu-latest-3.9.txt`` in this example.

Applying the lock file
----------------------
Expand Down
2 changes: 1 addition & 1 deletion docs/developer/tutorials/dev-install.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Install dependencies
--------------------

You can choose to either develop on the host machine using a `venv` (which
requires python 3.8 or later) or to run in a container under `VSCode
requires python 3.9 or later) or to run in a container under `VSCode
<https://code.visualstudio.com/>`_

.. tab-set::
Expand Down
2 changes: 1 addition & 1 deletion docs/user/tutorials/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Installation
Check your version of python
----------------------------

You will need python 3.8 or later. You can check your version of python by
You will need python 3.9 or later. You can check your version of python by
typing into a terminal::

$ python3 --version
Expand Down
7 changes: 3 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ name = "tickit"
classifiers = [
"Development Status :: 4 - Beta",
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
]
Expand All @@ -28,7 +27,7 @@ dependencies = [
dynamic = ["version"]
license.file = "LICENSE"
readme = "README.rst"
requires-python = ">=3.8"
requires-python = ">=3.9"

[project.optional-dependencies]
dev = [
Expand Down Expand Up @@ -127,8 +126,8 @@ skipsdist=True
# Don't create a virtualenv for the command, requires tox-direct plugin
direct = True
passenv = *
allowlist_externals =
pytest
allowlist_externals =
pytest
pre-commit
mypy
sphinx-build
Expand Down
2 changes: 1 addition & 1 deletion src/tickit/core/management/event_router.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
from collections import defaultdict, deque
from functools import cached_property
from typing import DefaultDict, Dict, Iterable, Mapping, Optional, Set, Union, overload

from tickit.core.components.component import ComponentConfig
from tickit.core.typedefs import ComponentID, ComponentPort, PortID
from tickit.utils.compat.functools_compat import cached_property

#: A mapping of component output ports to component input ports with defaults
Default_Wiring_Struct = DefaultDict[
Expand Down
14 changes: 0 additions & 14 deletions src/tickit/utils/compat/functools_compat.py

This file was deleted.