Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added type aliases #144

Merged
merged 1 commit into from
Jul 18, 2023
Merged

added type aliases #144

merged 1 commit into from
Jul 18, 2023

Conversation

rosesyrett
Copy link
Contributor

solves #117

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #144 (70cad53) into master (6e22b8d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 70cad53 differs from pull request most recent head 815a14e. Consider uploading reports for the commit 815a14e to get more accurate results

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   92.48%   92.50%   +0.01%     
==========================================
  Files          45       45              
  Lines        1225     1227       +2     
==========================================
+ Hits         1133     1135       +2     
  Misses         92       92              
Impacted Files Coverage Δ
src/tickit/core/components/component.py 96.29% <100.00%> (ø)
src/tickit/core/management/schedulers/base.py 97.95% <100.00%> (ø)
src/tickit/core/typedefs.py 91.83% <100.00%> (+0.34%) ⬆️

@rosesyrett rosesyrett mentioned this pull request Jul 10, 2023
@rosesyrett rosesyrett force-pushed the type_alias_for_message_types branch from 70cad53 to 815a14e Compare July 11, 2023 08:26
Copy link
Collaborator

@abbiemery abbiemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not possible to have the aliases declared in the same way as the other typedefs?

@tpoliaw
Copy link
Collaborator

tpoliaw commented Jul 13, 2023

Is it not possible to have the aliases declared in the same way as the other typedefs?

As in using NewTypes? I think that would mean you had to wrap every use with ComponentOutput(...) where they're used to avoid upsetting the type checker. TypeAliases mean the rest of the code doesn't have to change.

@rosesyrett rosesyrett merged commit ad1ca51 into master Jul 18, 2023
@abbiemery abbiemery deleted the type_alias_for_message_types branch July 19, 2023 10:24
rosesyrett added a commit that referenced this pull request Jul 21, 2023
This change introduces simple type aliases to improve readability for distinguishing between component input and output types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants