Make database file optional for EpicsAdapter #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 92.48% 93.23% +0.74%
==========================================
Files 45 45
Lines 1225 1226 +1
==========================================
+ Hits 1133 1143 +10
+ Misses 92 83 -9
|
joeshannon
commented
Jun 29, 2023
abbiemery
reviewed
Jul 4, 2023
There was a problem hiding this comment.
Seams okay to me, would probably be worth putting a test in for the different cases. Also what do you think about writing an epics adapter for one of the example devices, maybe the amplifier? It would be without a db and could be run with the work rose is doing for system tests.
|
Yeah that sounds like a good idea. Will take a look at that tomorrow. |
joeshannon
force-pushed
the
epics-optional-db-file
branch
from
388f84c to
6fc4afa
Compare
joeshannon
commented
Jul 11, 2023
abbiemery
requested changes
Jul 12, 2023
joeshannon
force-pushed
the
epics-optional-db-file
branch
from
6fc4afa to
f4de9b8
Compare
joeshannon
force-pushed
the
epics-optional-db-file
branch
from
f4de9b8 to
4779811
Compare
This is to make clear that the method is concerned with loading an actual db file.
joeshannon
force-pushed
the
epics-optional-db-file
branch
from
4779811 to
6dc6cd4
Compare
joeshannon
added a commit
to DiamondLightSource/tickit-devices
that referenced
this pull request
Jul 13, 2023
The db_file parameter has been changed to an optional parameter. See DiamondLightSource/tickit#134
abbiemery
pushed a commit
to DiamondLightSource/tickit-devices
that referenced
this pull request
Jul 25, 2023
The db_file parameter has been changed to an optional parameter. See DiamondLightSource/tickit#134
abbiemery
pushed a commit
to DiamondLightSource/tickit-devices
that referenced
this pull request
Jul 25, 2023
The db_file parameter has been changed to an optional parameter. See DiamondLightSource/tickit#134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.