Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling mistakes #129

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Fix spelling mistakes #129

merged 2 commits into from
Jun 29, 2023

Conversation

joeshannon
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #129 (4a3c284) into master (cd428de) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files          45       45           
  Lines        1225     1225           
=======================================
  Hits         1133     1133           
  Misses         92       92           
Impacted Files Coverage Δ
src/tickit/adapters/composed.py 60.00% <ø> (ø)
src/tickit/adapters/epicsadapter/adapter.py 87.75% <ø> (ø)
src/tickit/adapters/epicsadapter/ioc_manager.py 50.00% <ø> (ø)
src/tickit/adapters/httpadapter.py 51.42% <ø> (ø)
...apters/interpreters/command/command_interpreter.py 96.77% <ø> (ø)
...kit/adapters/interpreters/command/regex_command.py 100.00% <ø> (ø)
...t/adapters/interpreters/endpoints/http_endpoint.py 100.00% <ø> (ø)
...pters/interpreters/wrappers/joining_interpreter.py 100.00% <ø> (ø)
src/tickit/core/adapter.py 85.71% <ø> (ø)
src/tickit/core/components/system_simulation.py 97.77% <ø> (ø)
... and 13 more

@@ -60,7 +60,8 @@ def add_wakeup(self, component: ComponentID, when: SimTime) -> None:
self.new_wakeup.set()

async def run_forever(self) -> None:
"""Perform an intial tick then continiously schedule ticks according to wakeups.
"""Perform an initial tick then continuously schedule ticks according to
wakeups.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to split this over two lines for flake8 but now pydocstyle has a warning in vs code.
Is this the correct way to format this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does indenting the line remove the warning?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the Google style guide which Pydocstyle is configured to follow:

A docstring should be organized as a summary line (one physical line not exceeding 80 characters) terminated by a period, question mark, or exclamation point. When writing more (encouraged), this must be followed by a blank line, followed by the rest of the docstring starting at the same cursor position as the first quote of the first line. There are more formatting guidelines for docstrings below.

Basically, you gotta remove some words

Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garryod
Copy link
Member

garryod commented Jun 28, 2023

Ooof, my spelling is bad

@joeshannon joeshannon merged commit ad4499e into master Jun 29, 2023
@joeshannon joeshannon deleted the typos branch June 29, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants