Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt new skeleton #101

Merged
merged 85 commits into from
Feb 15, 2023
Merged

Adopt new skeleton #101

merged 85 commits into from
Feb 15, 2023

Conversation

abbiemery
Copy link
Collaborator

Adopt the new python3 pip skeleton and dropping support for python3.7.

coretl and others added 30 commits January 7, 2022 11:46
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [black](https://github.com/psf/black) from 22.6.0 to 22.8.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@22.6.0...22.8.0)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
There are now developer and user guides. The version switcher is native
to the theme so added a script to generate it.
This saves another runner starting up just for this
Fixing a bug that occurs when releasing. (This is already fixed in the skeleton-cli project but failed to get copied to skeleton).
Pin pydata-sphinx-theme to allow the build to complete
pydata/pydata-sphinx-theme#987
Use the official Python Packaging Authority (PyPA) Action to publish to PyPI
Bumps [black](https://github.com/psf/black) from 22.8.0 to 22.10.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@22.8.0...22.10.0)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Translate punctuation and unicode in branch names to _
- Environment variable no longer needs to be set
- All commands run with tox-direct by default
- All environment variables passed through
- Moved wheel and sdist creation to the dist job
- Rely on the test matrix to run tests
- Simplified container build to make minimal for build and runtime
  and use wheel from 'dist': only publish to GHCR for tagged builds
- Create separate requirements-*.txt for each of the test matrix
- Fix actions-gh-pages version and don't run it for dependabot
- Move Dockerfile to .devcontainer and use as context to improve
  build times
- Other minor improvements and simplifications
@abbiemery abbiemery self-assigned this Feb 1, 2023
@abbiemery abbiemery mentioned this pull request Feb 2, 2023
Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine other than a few missed renamings

docs/developer/how-to/make-release.rst Outdated Show resolved Hide resolved
docs/developer/tutorials/dev-install.rst Outdated Show resolved Hide resolved
docs/developer/tutorials/dev-install.rst Outdated Show resolved Hide resolved
docs/developer/tutorials/dev-install.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
@callumforrester
Copy link
Contributor

@gilesknap see my review comments. Wondering if there is any way to detect and avoid these name conflicts during adoptions.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #101 (88c1253) into master (13d1e3a) will decrease coverage by 0.81%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   98.59%   97.79%   -0.81%     
==========================================
  Files          69       70       +1     
  Lines        2139     2179      +40     
==========================================
+ Hits         2109     2131      +22     
- Misses         30       48      +18     
Impacted Files Coverage Δ
src/tickit/__main__.py 100.00% <ø> (ø)
src/tickit/adapters/composed.py 90.00% <ø> (ø)
src/tickit/adapters/epicsadapter/__init__.py 100.00% <ø> (ø)
src/tickit/adapters/epicsadapter/adapter.py 100.00% <ø> (ø)
src/tickit/adapters/epicsadapter/ioc_manager.py 100.00% <ø> (ø)
src/tickit/adapters/httpadapter.py 100.00% <ø> (ø)
...c/tickit/adapters/interpreters/command/__init__.py 100.00% <ø> (ø)
...apters/interpreters/command/command_interpreter.py 96.77% <ø> (ø)
...kit/adapters/interpreters/command/regex_command.py 100.00% <ø> (ø)
...t/adapters/interpreters/endpoints/http_endpoint.py 100.00% <ø> (ø)
... and 69 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@abbiemery abbiemery merged commit 14d9471 into master Feb 15, 2023
@abbiemery abbiemery deleted the adopt-new-skeleton branch February 28, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants