-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt new skeleton #101
Adopt new skeleton #101
Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [black](https://github.com/psf/black) from 22.6.0 to 22.8.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.6.0...22.8.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
There are now developer and user guides. The version switcher is native to the theme so added a script to generate it.
This saves another runner starting up just for this
Fixing a bug that occurs when releasing. (This is already fixed in the skeleton-cli project but failed to get copied to skeleton).
Co-authored-by: Tom C (DLS) <[email protected]>
Pin pydata-sphinx-theme to allow the build to complete pydata/pydata-sphinx-theme#987
Use the official Python Packaging Authority (PyPA) Action to publish to PyPI
Bumps [black](https://github.com/psf/black) from 22.8.0 to 22.10.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.8.0...22.10.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Translate punctuation and unicode in branch names to _
- Environment variable no longer needs to be set - All commands run with tox-direct by default - All environment variables passed through
- Moved wheel and sdist creation to the dist job - Rely on the test matrix to run tests - Simplified container build to make minimal for build and runtime and use wheel from 'dist': only publish to GHCR for tagged builds - Create separate requirements-*.txt for each of the test matrix - Fix actions-gh-pages version and don't run it for dependabot - Move Dockerfile to .devcontainer and use as context to improve build times - Other minor improvements and simplifications
This is a temporary measure untill depricated asyncio changes have been adressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine other than a few missed renamings
@gilesknap see my review comments. Wondering if there is any way to detect and avoid these name conflicts during adoptions. |
Co-authored-by: Callum Forrester <[email protected]>
Co-authored-by: Callum Forrester <[email protected]>
Co-authored-by: Callum Forrester <[email protected]>
Co-authored-by: Callum Forrester <[email protected]>
Co-authored-by: Callum Forrester <[email protected]>
Co-authored-by: Callum Forrester <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
- Coverage 98.59% 97.79% -0.81%
==========================================
Files 69 70 +1
Lines 2139 2179 +40
==========================================
+ Hits 2109 2131 +22
- Misses 30 48 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Adopt the new python3 pip skeleton and dropping support for python3.7.