-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have RegexCommand.parse return more information #93
Comments
MattPrit
added a commit
that referenced
this issue
Sep 5, 2022
MattPrit
added a commit
that referenced
this issue
Sep 5, 2022
Closed
MattPrit
added a commit
that referenced
this issue
Sep 5, 2022
MattPrit
added a commit
that referenced
this issue
Sep 5, 2022
Closed
MattPrit
added a commit
that referenced
this issue
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Required for #90
The more complex
MultiCommandInterpreter
requires more information to be returned formparse
. Specifically, it requires information about where within the message a match is found; these indices need to be with respect to the original message, not (if applicable) the message after it has been decoded. This could be achieved by encoding the regex pattern rather than decoding the message whenformat
is notNone
.Since there will be changes to the return signature of
Command.parse
, thehandle
method ofCommandInterpreter
will need to be updated.The text was updated successfully, but these errors were encountered: