Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how we use the rsync module specified in the machine configuration #476

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

d-j-hatton
Copy link
Contributor

Currently we assume that the rsync module name forms part of the path but this isn't necessarily the case. We should specify the whole rsync module path as the rsync_basepath in the configuration and insert the module name directly where we need it (at the point of construction of the rsync command).

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 27.31%. Comparing base (51fd6ad) to head (341b6c7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   27.31%   27.31%   -0.01%     
==========================================
  Files          78       78              
  Lines       10159    10161       +2     
  Branches     1338     1338              
==========================================
  Hits         2775     2775              
- Misses       7288     7290       +2     
  Partials       96       96              

src/murfey/instrument_server/api.py Dismissed Show dismissed Hide dismissed
Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLEM workflow works just fine after the changes are implemented. This should go in before PR #477, which also makes changes to the TUI files.

@d-j-hatton d-j-hatton merged commit 3308176 into main Jan 31, 2025
17 checks passed
@d-j-hatton d-j-hatton deleted the rsync-module-change branch January 31, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants