Load RabbitMQ credentials directly using PikaTransport object #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tieneupin
added
bug
tieneupin
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
=======================================
Coverage 26.95% 26.95%
=======================================
Files 75 75
Lines 10243 10243
Branches 1351 1351
=======================================
Hits 2761 2761
Misses 7392 7392
Partials 90 90 |
d-j-hatton
reviewed
Jan 10, 2025
src/murfey/server/__init__.py
Outdated
| _set_up_transport(args.transport) | ||
| # Load RabbitMQ configuration and set up the connection | ||
| PikaTransport().load_configuration_file(security_config.rabbitmq_credentials) | ||
| _set_up_transport("pika") |
There was a problem hiding this comment.
I think this should be _set_up_transport("PikaTransport")
…s to indicate this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've removed the Zocalo configuration dependency, we import and use PikaTransport directly to load the RabbitMQ configuration