633 system tests on k8s #793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
=======================================
Coverage 86.90% 86.91%
=======================================
Files 102 102
Lines 6956 6960 +4
=======================================
+ Hits 6045 6049 +4
Misses 911 911
|
rtuck99
force-pushed
the
633_system_tests_on_k8s
branch
from
f7e9978 to
6ed7f61
Compare
… was not working reliably
Move from podman to podman-compose
Helmcharts for deployment to k8s cluster Updates to modify secrets handling
Allow fixtures to be configurable to match the test db
rtuck99
force-pushed
the
633_system_tests_on_k8s
branch
from
6ed7f61 to
b02c969
Compare
| @@ -165,7 +166,7 @@ legacy_tox_ini = """ | |||
| [tox] | |||
| skipsdist=True | |||
|
|
|||
| [testenv:{pre-commit,type-checking,tests,docs}] | |||
| [testenv:{pre-commit,type-checking,tests,docs,systemtests}] | |||
There was a problem hiding this comment.
Nit: We've been calling it system-test in other places, not really bothered but would be nice to be consistent
There was a problem hiding this comment.
Unfortunately, dashes have a special meaning within tox:
https://tox.wiki/en/latest/user_guide.html
Test environment names can consist of alphanumeric characters and dashes; for example: py311-django42. The name will be split on dashes into multiple factors, meaning py311-django42 will be split into two factors: py311 and django42.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses
The changes here mainly consist of changes to the unit tests to allow the ISPyB endpoint to be configured via the
ISPYB_CONFIG_PATHduring tests, which was previously overridden.Also there are changes to allow sample ID, visit and suchlike to be configured as an interim so that it is still possible to run the system tests individually locally against the
ispyb_hyperion_dev.cfgdatabase.The actual system test infrastructure can be found in the associated GitLab merge request