This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Create panda subdirectory within panda plan #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
olliesilvester
changed the title
olliesilvester
changed the title
olliesilvester
force-pushed
the
1339_fix_panda_pcap
branch
from
ed9ad91 to
9e341bd
Compare
d-perl
previously approved these changes
May 16, 2024
tests/unit_tests/experiment_plans/test_flyscan_xray_centre_plan.py
Outdated
Show resolved
Hide resolved
tests/unit_tests/experiment_plans/test_panda_flyscan_xray_centre_plan.py
Outdated
Show resolved
Hide resolved
DominicOram
previously requested changes
May 16, 2024
| ) | ||
| panda_directory = Path(parameters.detector_params.directory) | ||
|
|
||
| # Don't create directory once implemented in ophyd-async |
There was a problem hiding this comment.
Should: Does this have an ophyd_async issue we can link to?
| get_directory_provider().update( | ||
| directory=Path(parameters.detector_params.directory) | ||
| ) | ||
| panda_directory = Path(parameters.detector_params.directory) |
There was a problem hiding this comment.
Should: I think parameters.storage_directory is where we get the detector directory from originally so we should probably use that here rather than digging into the detector.
There was a problem hiding this comment.
Should: I'm also mildly concerned that people will get detector and panda data confused. Can we put it in a panda subfolder for now?
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/1339_fix_panda_pcap Create panda subdirectory within panda plan
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1339
Link to dodal PR (if required): #516
(remember to update
setup.cfgwith the dodal commit tag if you need it for tests to pass!)To test: