Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

1293 remove barcode #1340

Merged
merged 2 commits into from
Apr 29, 2024
Merged

1293 remove barcode #1340

merged 2 commits into from
Apr 29, 2024

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Apr 29, 2024

Fixes #1293

Link to dodal PR (if required): N/A
(remember to update setup.cfg with the dodal commit tag if you need it for tests to pass!)

To test:

  1. All tests should pass
  2. DataCollectionGroup info should be stored in ispyb as normal

@rtuck99
Copy link
Contributor Author

rtuck99 commented Apr 29, 2024

I didn't add the create_group method as described, as it didn't really seem to add anything. After removal of the barcode and subsequent removal of all population of DataCollectionGroupInfo during updates, there is no "worrying about groups" after activity_start, you just let ispyb_store populate your ispyb_ids and then forget about it.

The only possible benefit might be some separation in ispyb_store.begin_or_update_deposition() but at the expense of managing the ispyb connection across the separate calls during begin_deposition().

Copy link
Collaborator

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this cleans things up quite a lot, thanks!

@DominicOram DominicOram merged commit 1eaa245 into main Apr 29, 2024
17 checks passed
@DominicOram DominicOram deleted the 1293_remove_barcode branch April 29, 2024 19:28
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…Source/1293_remove_barcode

1293 remove barcode
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create data collection group once on start document
2 participants