Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

(#1321) Update references to nexgen modules #1323

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

d-perl
Copy link
Contributor

@d-perl d-perl commented Apr 22, 2024

Fixes #1321

Merge together with creating a new Nexgen release
Note: tests are expected to fail (with ImportErrors from nexgen) against the current release or older version of nexgen

To test:

  1. See tests pass with nexgen main

Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, please don't forget to pin nexgen version to >=0.9.1

@d-perl d-perl requested a review from noemifrisina April 23, 2024 10:19
Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@d-perl d-perl merged commit 21a2c1e into main Apr 23, 2024
10 checks passed
@d-perl d-perl deleted the 1321_update_references_to_nexgen branch April 23, 2024 10:40
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…Source/1321_update_references_to_nexgen

(DiamondLightSource/hyperion#1321) Update references to nexgen modules
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor nexus writer code to work with new versions of nexgen
2 participants