This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Add an endpoint to write DEBUG level logs
#1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Thanks, works as expected some minor things, take them or leave them.
Could: If I delete the hyperion.log debug file then call the flush it doesn't make a new one, I think this is an edge case though so up to you if you want to address it.
Could: Ideally I think exposing the handlers out of log.py is a bit messy and would rather just expose a flush_debug function but I like that we return the filename in the status so maybe flush_debug should return the filename it flushes too? Not sure, up to you if you think it's cleaner or not
src/hyperion/log.py
Outdated
| __logger_handlers = handlers | ||
|
|
||
|
|
||
| def get_memory_handler() -> CircularMemoryHandler: |
There was a problem hiding this comment.
Nit: I think get_debug_handler would be slightly clearer as it's logging the debug not the memory
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/1201_dump_debug_logs_endpoint Add an endpoint to write `DEBUG` level logs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1201, fixes #1208
To test:
curl -X PUT http://127.0.0.1:5005/flush_debug_logand see that this works