Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Full centring algorithm #499

Closed
DominicOram opened this issue Jan 26, 2023 · 5 comments · Fixed by #852
Closed

Full centring algorithm #499

DominicOram opened this issue Jan 26, 2023 · 5 comments · Fixed by #852
Assignees
@DominicOram

Comments

@DominicOram
Copy link
Collaborator

DominicOram commented Jan 26, 2023 •
edited
Loading

To do a full centring Hyperion will need to:

  • Move to zoom one (applying flat field)
  • Move to tip (with offset) at 0
  • Move to tip (with offset) at 90
  • Grid detect at 90
  • Grid detect at 0
  • Xray centre
@DominicOram DominicOram moved this to Backlog in Hyperion Jan 26, 2023
@DominicOram
Copy link
Collaborator Author

See https://jira.diamond.ac.uk/browse/I03-682

@DominicOram DominicOram moved this from Backlog to Todo This Sprint in Hyperion Mar 6, 2023
@DominicOram DominicOram mentioned this issue Mar 6, 2023
Closed
@DominicOram DominicOram mentioned this issue May 11, 2023
Closed
11 tasks
@DominicOram
Copy link
Collaborator Author

Initial tests done on the multipin_tests branch in bluesky/artemis_v5.1.0

@DominicOram
Copy link
Collaborator Author

Look into how easy it would be to turn off centring after robot load

@DominicOram DominicOram mentioned this issue Jul 21, 2023
Closed
@DominicOram
Copy link
Collaborator Author

Code currently on the beamline is doing this with centring turned off in GDA

@DominicOram DominicOram self-assigned this Jul 21, 2023
@DominicOram DominicOram moved this from Todo This Sprint to In Progress in Hyperion Jul 21, 2023
DominicOram added a commit that referenced this issue Jul 28, 2023
@DominicOram
(#499) Add function to initially bring pin into view
f00a8cb
DominicOram added a commit that referenced this issue Jul 28, 2023
@DominicOram
(#499) Improve smargon ophyd sim
e17d527
DominicOram added a commit that referenced this issue Jul 28, 2023
@DominicOram
(#499) Add helper functions for moving smargon during pin tip centring
727197a
DominicOram added a commit that referenced this issue Jul 28, 2023
@DominicOram
(#499) Add pin tip centring plan
45cf153
DominicOram added a commit that referenced this issue Jul 28, 2023
@DominicOram
(#499) Refactor calculation for beam centre move to central plan
449b7bb
DominicOram added a commit that referenced this issue Jul 28, 2023
@DominicOram
(#499) Use common code for calculating beam distance move
50c7c1f
DominicOram added a commit that referenced this issue Jul 28, 2023
@DominicOram
(#499) Move wait for pin tip into a common area
56a6144
@DominicOram DominicOram mentioned this issue Jul 28, 2023
Merged
@DominicOram
Copy link
Collaborator Author

#832 contains the pin tip algorithm that covers the second two points. In a new PR I will:

  • Create a new centring plan that uses pin tip then full grid
  • Move the zoom setting into top level centring
  • Allow passing in the params for centring so that we can use it for multipin too

DominicOram added a commit that referenced this issue Aug 1, 2023
@DominicOram
(#499) Check motor limits before moving
6ab24b5
DominicOram added a commit that referenced this issue Aug 1, 2023
@DominicOram
(#499) Fix bad merge
ff0556b
@DominicOram DominicOram mentioned this issue Aug 1, 2023
Closed
DominicOram added a commit that referenced this issue Aug 3, 2023
@DominicOram
(#499) Add an externally visible plan to pin tip centre then xray centre
fa7a00f
DominicOram added a commit that referenced this issue Aug 3, 2023
@DominicOram
(#499) Move prepare data collection out of full_grid_scan_plan
4b0dd46
DominicOram added a commit that referenced this issue Aug 3, 2023
@DominicOram
(#499) Add parallel arming to pin tip then xray
ddd8e44
DominicOram added a commit to DiamondLightSource/dodal that referenced this issue Aug 4, 2023
@DominicOram
(DiamondLightSource/hyperion#499) Use specific hyperion OAV centring …
d9010cb 
…config
DominicOram added a commit that referenced this issue Aug 4, 2023
@DominicOram
(#499) Set detector parameters before starting arming
11c7468
@DominicOram DominicOram mentioned this issue Aug 4, 2023
Closed
DominicOram added a commit that referenced this issue Aug 4, 2023
@DominicOram
(#499) Use a different OAVCentring file for full centring, which uses…
328a365 
… zoom x1.0
@DominicOram DominicOram mentioned this issue Aug 4, 2023
Merged
@DominicOram DominicOram moved this from In Progress to Review in Hyperion Aug 4, 2023
DominicOram added a commit that referenced this issue Aug 9, 2023
@DominicOram
(#499) Add fixes found in beamline testing
37e2ba0
DominicOram added a commit that referenced this issue Aug 9, 2023
@DominicOram
(#499) Add grid width to pin centre then xray centre
0503e59
DominicOram added a commit that referenced this issue Aug 9, 2023
@DominicOram
(#499) Use test OAV config files
545709c
DominicOram added a commit that referenced this issue Aug 9, 2023
@DominicOram
(#499) Use test OAV config files again
c78ba4b
DominicOram added a commit that referenced this issue Aug 17, 2023
@DominicOram @Tom-Willemsen
(#499) Add type hint
327d5ce 
Co-authored-by: Tom Willemsen <[email protected]>
DominicOram added a commit that referenced this issue Aug 17, 2023
@DominicOram
(#499) Fixes after review
080e6c1
DominicOram added a commit that referenced this issue Aug 21, 2023
@DominicOram
(#499) Fix merge issue
10694ed
@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion Aug 21, 2023
@DominicOram DominicOram mentioned this issue Jul 28, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DominicOram DominicOram

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add plan to do pin tip centring then xray centring DiamondLightSource/hyperion
1 participant
@DominicOram