Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Log no diffraction into ispyb #487

Closed
DominicOram opened this issue Jan 24, 2023 · 0 comments · Fixed by #515
Closed

Log no diffraction into ispyb #487

DominicOram opened this issue Jan 24, 2023 · 0 comments · Fixed by #515
Assignees
@d-perl

Comments

@DominicOram
Copy link
Collaborator

When we find no diffraction in the sample we should put this into the isypb comments

Acceptance Criteria

  • No diffraction results from zocalo causes message in the ispyb comments
  • System/unit tests for this
@DominicOram DominicOram moved this to Backlog in Hyperion Jan 24, 2023
@DominicOram DominicOram mentioned this issue Jan 24, 2023
Merged
@d-perl d-perl self-assigned this Feb 1, 2023
@DominicOram DominicOram moved this from Backlog to In Progress in Hyperion Feb 1, 2023
@d-perl d-perl mentioned this issue Feb 1, 2023
Merged
@DominicOram DominicOram moved this from In Progress to Review in Hyperion Feb 1, 2023
DominicOram added a commit that referenced this issue Feb 6, 2023
@DominicOram
(#487) Fixed tests for no diffraction
45c739d
@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion Feb 9, 2023
d-perl added a commit that referenced this issue May 10, 2024
@d-perl
(#487) Improve logging formatting for documents
a81fce8
@d-perl d-perl mentioned this issue May 10, 2024
Merged
@DominicOram DominicOram moved this from Done to Review in Hyperion May 10, 2024
d-perl added a commit that referenced this issue May 10, 2024
@d-perl
(#487) Improve logging formatting for documents
05d2dc1
d-perl added a commit that referenced this issue May 10, 2024
@d-perl
(#487) Improve logging formatting for documents
611a7b1
d-perl added a commit that referenced this issue May 10, 2024
@d-perl
(#487) Improve logging formatting for params
a785580
d-perl added a commit that referenced this issue May 10, 2024
@d-perl
(#487) fix test
be97b15
@DominicOram DominicOram moved this from Review to Done in Hyperion May 10, 2024
d-perl added a commit that referenced this issue May 14, 2024
@d-perl
(#487) format missed docs
24f130a
d-perl added a commit that referenced this issue May 16, 2024
@d-perl
Merge pull request #1373 from DiamondLightSource/487_improve_logging_…
9fa6d7b 
…formatting

(Dodal #487) Improve logging formatting for documents
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@d-perl
(DiamondLightSource/hyperion#487) Improve logging formatting for docu…
a32acf3 
…ments
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@d-perl
(DiamondLightSource/hyperion#487) Improve logging formatting for params
f1dda09
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@d-perl
(DiamondLightSource/hyperion#487) fix test
1170aa8
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@d-perl
(DiamondLightSource/hyperion#487) format missed docs
f50dae9
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@d-perl
Merge pull request DiamondLightSource/hyperion#1373 from DiamondLight…
36e2848 
…Source/487_improve_logging_formatting

(Dodal DiamondLightSource/hyperion#487) Improve logging formatting for documents
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@d-perl d-perl

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve logging to ispyb when there is no diffraction DiamondLightSource/hyperion
2 participants
@DominicOram @d-perl