Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Do not put position into ispyb for gridscans #1302

Closed
DominicOram opened this issue Apr 9, 2024 · 0 comments · Fixed by #1401
Closed

Do not put position into ispyb for gridscans #1302

DominicOram opened this issue Apr 9, 2024 · 0 comments · Fixed by #1401
Assignees
@rtuck99

Comments

@DominicOram
Copy link
Collaborator

As discussed at https://diamondlightsource.slack.com/archives/C048RD0KFFF/p1712656243118199 we should not put position in the database for gridscans as it is in not well defined what that means.

Acceptance Criteria

  • Gridscans no longer put position into ispyb
@DominicOram DominicOram moved this to Backlog in Hyperion Apr 9, 2024
@DominicOram DominicOram moved this from Backlog to Candidates for Next Sprint in Hyperion May 10, 2024
@rtuck99 rtuck99 self-assigned this May 20, 2024
@DominicOram DominicOram moved this from Candidates for Next Sprint to In Progress in Hyperion May 20, 2024
rtuck99 added a commit that referenced this issue May 21, 2024
@rtuck99
(#1302) Remove position populate from ispyb callback code
2cc6f79
rtuck99 added a commit that referenced this issue May 21, 2024
@rtuck99
(#1302) Remove position from external ispyb gridscan parameters
a600bcc
rtuck99 added a commit that referenced this issue May 21, 2024
@rtuck99
(#1302) Remove position populate from ispyb callback code
a217ec0
rtuck99 added a commit that referenced this issue May 21, 2024
@rtuck99
(#1302) Remove position from external ispyb gridscan parameters
ea4aeec
rtuck99 added a commit that referenced this issue May 21, 2024
@rtuck99
(#1302) fixes for system tests (WIP)
9631d62
@rtuck99 rtuck99 mentioned this issue May 21, 2024
Merged
rtuck99 added a commit that referenced this issue May 21, 2024
@rtuck99
(#1302) Remove surplus JSON test file, add position test to rotation …
16a1704 
…ispyb system test
rtuck99 added a commit that referenced this issue May 21, 2024
@rtuck99
(#1302) Make pyright happy
bf2e6e9
rtuck99 added a commit that referenced this issue May 23, 2024
@rtuck99
1302 do not put position into ispyb for gridscans (#1401)
90721aa 
* (#1302) Remove position populate from ispyb callback code

* (#1302) Remove position from external ispyb gridscan parameters

* (#1302) fixes for system tests (WIP)

* (#1302) Remove surplus JSON test file, add position test to rotation ispyb system test

* (#1302) Make pyright happy
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hyperion May 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
1302 do not put position into ispyb for gridscans (DiamondLightSource…
86d5649 
…/hyperion#1401)

* (DiamondLightSource/hyperion#1302) Remove position populate from ispyb callback code

* (DiamondLightSource/hyperion#1302) Remove position from external ispyb gridscan parameters

* (DiamondLightSource/hyperion#1302) fixes for system tests (WIP)

* (DiamondLightSource/hyperion#1302) Remove surplus JSON test file, add position test to rotation ispyb system test

* (DiamondLightSource/hyperion#1302) Make pyright happy
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rtuck99 rtuck99

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1302 do not put position into ispyb for gridscans DiamondLightSource/hyperion
2 participants
@rtuck99 @DominicOram