Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Use event from grid detect to do ispyb deposition #1217

Closed
DominicOram opened this issue Mar 5, 2024 · 1 comment · Fixed by #1279
Closed

Use event from grid detect to do ispyb deposition #1217

DominicOram opened this issue Mar 5, 2024 · 1 comment · Fixed by #1279
Assignees
@rtuck99

Comments

@DominicOram
Copy link
Collaborator

DominicOram commented Mar 5, 2024 •
edited
Loading

Following #1146 we have a GridScanInfo object that we could easily create from an event at the grid detect stage e.g. do grid detect at 0 omega and produce one doc with that info then rotate and produce the next. To do this we would need to:

  • Move ispyb deposition to before grid detect (at least)
  • Emit these events
  • Use them in the callback
  • Remove the grid related stuff in ispyb_params
@DominicOram DominicOram moved this to Backlog in Hyperion Mar 5, 2024
@DominicOram DominicOram moved this from Backlog to Candidates for Next Sprint in Hyperion Mar 6, 2024
@d-perl d-perl mentioned this issue Mar 7, 2024
Merged
@DominicOram DominicOram moved this from Candidates for Next Sprint to Todo This Sprint in Hyperion Mar 8, 2024
@DominicOram DominicOram mentioned this issue Sep 2, 2024
Open
@DominicOram
Copy link
Collaborator Author

We think this will take ~3 days

@rtuck99 rtuck99 self-assigned this Mar 18, 2024
@DominicOram DominicOram moved this from Todo This Sprint to In Progress in Hyperion Mar 18, 2024
rtuck99 added a commit that referenced this issue Mar 22, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
69340f8 
* Move ispyb callback activation to before grid detect
* Fixup all the broken unit tests
* Separate descriptor constants from plan names
* Move callback activation wrapper to callback module
rtuck99 added a commit that referenced this issue Mar 22, 2024
@rtuck99
(#1217)
fa7239d 
* Remove upsert_dc_grid calls from hardware read ispyb updates
* Add units to GridScanInfo fields
* Move grid comment updates from hardware read to oav snapshot event
rtuck99 added a commit that referenced this issue Mar 22, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
f7e365e 
* Fix system tests
* Change comment to be specified as a value instead of a factory
rtuck99 added a commit that referenced this issue Mar 22, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
03713de 
* Remove ispyb params upper_left
rtuck99 added a commit that referenced this issue Mar 22, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
4754c0e 
* Remove oav_snapshot_callback.py
rtuck99 added a commit that referenced this issue Mar 22, 2024
@rtuck99
(#1217) Make pyright happy
af06d87
@rtuck99 rtuck99 mentioned this issue Mar 22, 2024
Merged
rtuck99 added a commit that referenced this issue Mar 22, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
1c47e58 
* Move ispyb callback activation to before grid detect
* Fixup all the broken unit tests
* Separate descriptor constants from plan names
* Move callback activation wrapper to callback module
rtuck99 added a commit that referenced this issue Mar 22, 2024
@rtuck99
(#1217)
a37d47f 
* Remove upsert_dc_grid calls from hardware read ispyb updates
* Add units to GridScanInfo fields
* Move grid comment updates from hardware read to oav snapshot event
rtuck99 added a commit that referenced this issue Mar 22, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
ce5a94b 
* Fix system tests
* Change comment to be specified as a value instead of a factory
rtuck99 added a commit that referenced this issue Mar 22, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
ec939e4 
* Remove ispyb params upper_left
rtuck99 added a commit that referenced this issue Mar 22, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
98b9b2e 
* Remove oav_snapshot_callback.py
rtuck99 added a commit that referenced this issue Mar 22, 2024
@rtuck99
(#1217) Make pyright happy
de7235f
@DominicOram DominicOram moved this from In Progress to Review in Hyperion Mar 25, 2024
rtuck99 added a commit that referenced this issue Apr 2, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
4f43be6 
* Move ispyb callback activation to before grid detect
* Fixup all the broken unit tests
* Separate descriptor constants from plan names
* Move callback activation wrapper to callback module
rtuck99 added a commit that referenced this issue Apr 2, 2024
@rtuck99
(#1217)
93f5208 
* Remove upsert_dc_grid calls from hardware read ispyb updates
* Add units to GridScanInfo fields
* Move grid comment updates from hardware read to oav snapshot event
rtuck99 added a commit that referenced this issue Apr 2, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
4d3c29e 
* Fix system tests
* Change comment to be specified as a value instead of a factory
rtuck99 added a commit that referenced this issue Apr 2, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
136a7f3 
* Remove ispyb params upper_left
rtuck99 added a commit that referenced this issue Apr 2, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
b7c5252 
* Remove oav_snapshot_callback.py
rtuck99 added a commit that referenced this issue Apr 2, 2024
@rtuck99
(#1217) Make pyright happy
7864007
rtuck99 added a commit that referenced this issue Apr 2, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
0407a2c 
* Move ispyb callback activation to before grid detect
* Fixup all the broken unit tests
* Separate descriptor constants from plan names
* Move callback activation wrapper to callback module
rtuck99 added a commit that referenced this issue Apr 11, 2024
@rtuck99
(#1217) Remove _hwscan_data_collection_info and make event handling m…
5dd5eb9 
…ore uniform in ispyb_callback_base.py as per PR review
rtuck99 added a commit that referenced this issue Apr 11, 2024
@rtuck99
(#1217) make pyright happy
662c1aa
rtuck99 added a commit that referenced this issue Apr 23, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
1192243 
* Move ispyb callback activation to before grid detect
* Fixup all the broken unit tests
* Separate descriptor constants from plan names
* Move callback activation wrapper to callback module
rtuck99 added a commit that referenced this issue Apr 23, 2024
@rtuck99
(#1217)
2e646da 
* Remove upsert_dc_grid calls from hardware read ispyb updates
* Add units to GridScanInfo fields
* Move grid comment updates from hardware read to oav snapshot event
rtuck99 added a commit that referenced this issue Apr 23, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
396208b 
* Fix system tests
* Change comment to be specified as a value instead of a factory
rtuck99 added a commit that referenced this issue Apr 23, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
36e1458 
* Remove ispyb params upper_left
rtuck99 added a commit that referenced this issue Apr 23, 2024
@rtuck99
(#1217) Use event from grid detect to do ispyb deposition
d236a1d 
* Remove oav_snapshot_callback.py
rtuck99 added a commit that referenced this issue Apr 23, 2024
@rtuck99
(#1217) Make pyright happy
c6012bd
rtuck99 added a commit that referenced this issue Apr 23, 2024
@rtuck99
(#1217) Only populate common DataCollectionInfo properties during act…
010dced 
…ivity_start() and eager create both xy and xz DataCollection, as per PR feedback
rtuck99 added a commit that referenced this issue Apr 23, 2024
@rtuck99
(#1217) Fix broken ispyb system tests
13c7429
rtuck99 added a commit that referenced this issue Apr 23, 2024
@rtuck99
(#1217) Fix issues from PR review
6edb5a8 
Remove GridScanInfo
rtuck99 added a commit that referenced this issue Apr 23, 2024
@rtuck99
(#1217) Remove _hwscan_data_collection_info and make event handling m…
7b19b8f 
…ore uniform in ispyb_callback_base.py as per PR review
rtuck99 added a commit that referenced this issue Apr 23, 2024
@rtuck99
(#1217) make pyright happy
36436f3
rtuck99 added a commit that referenced this issue Apr 23, 2024
@rtuck99
(#1217) Response to PR review comments
7779ab7 
* Remove unused methods and method parameters
* Extract common call to update_deposition() from ispyb_callback_base handler methods
* Tidy up initialisation of DataCollectionInfo
rtuck99 added a commit that referenced this issue Apr 23, 2024
@rtuck99
(#1217) Make pyright happy
95959bc
@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion Apr 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1217) Use event from grid detect to do i…
56ed3db 
…spyb deposition

* Move ispyb callback activation to before grid detect
* Fixup all the broken unit tests
* Separate descriptor constants from plan names
* Move callback activation wrapper to callback module
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1217)
677183b 
* Remove upsert_dc_grid calls from hardware read ispyb updates
* Add units to GridScanInfo fields
* Move grid comment updates from hardware read to oav snapshot event
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1217) Use event from grid detect to do i…
8df9ed3 
…spyb deposition

* Fix system tests
* Change comment to be specified as a value instead of a factory
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1217) Use event from grid detect to do i…
c969f7c 
…spyb deposition

* Remove ispyb params upper_left
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1217) Use event from grid detect to do i…
efea69f 
…spyb deposition

* Remove oav_snapshot_callback.py
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1217) Make pyright happy
aedd209
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1217) Only populate common DataCollectio…
c814064 
…nInfo properties during activity_start() and eager create both xy and xz DataCollection, as per PR feedback
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1217) Fix broken ispyb system tests
49fb1d9
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1217) Fix issues from PR review
716cc18 
Remove GridScanInfo
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1217) Remove _hwscan_data_collection_inf…
19fe1e8 
…o and make event handling more uniform in ispyb_callback_base.py as per PR review
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1217) make pyright happy
653776a
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1217) Response to PR review comments
f4cddaa 
* Remove unused methods and method parameters
* Extract common call to update_deposition() from ispyb_callback_base handler methods
* Tidy up initialisation of DataCollectionInfo
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1217) Make pyright happy
ebebe5b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rtuck99 rtuck99

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1217 Use event from grid detect to do ispyb deposition DiamondLightSource/hyperion
2 participants
@rtuck99 @DominicOram