-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update i20-1 to use device_factory #922
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #922 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 159 159
Lines 6578 6581 +3
=======================================
+ Hits 6424 6427 +3
Misses 154 154 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all connection fails but caget fails also
Appears to be trying to connect to i20? Should NOT be merged until this is resolved. |
ah yes the behavior of |
9e1a549
to
080936c
Compare
Reveals #926 on attempting to connect- |
080936c
to
7134287
Compare
i20-1 seems to be unhappy? |
c2cb7b9
to
2fb66bf
Compare
8ff7dc7
to
cb27c17
Compare
after this is merged we can deploy the latest blueapi version as 0.6.1 is misbehaving |
cb27c17
to
b4747e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran dodal connect i20-1
and it seems happy, approved
b4747e1
to
91afeae
Compare
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}