Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i20-1 to use device_factory #922

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Update i20-1 to use device_factory #922

merged 3 commits into from
Feb 4, 2025

Conversation

DiamondJoseph
Copy link
Contributor

Instructions to reviewer on how to test:

  1. Test beamline can still connect

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (9e3ef3c) to head (91afeae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #922   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         159      159           
  Lines        6578     6581    +3     
=======================================
+ Hits         6424     6427    +3     
  Misses        154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stan-dot stan-dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all connection fails but caget fails also

@DiamondJoseph
Copy link
Contributor Author

DiamondJoseph commented Nov 26, 2024

xspress3: NotConnected:
    channels: NotConnected:
        1: NotConnected:
            update_arrays: NotConnected: ca://BL20I-EA-DET-03:C1_SCAS:TS:TSAcquire
            roi_high_limit: NotConnected: ca://BL20I-EA-DET-03:C1_SCA5_HLM

Appears to be trying to connect to i20? Should NOT be merged until this is resolved.

@DiamondJoseph DiamondJoseph marked this pull request as draft November 26, 2024 14:14
@stan-dot
Copy link
Contributor

ah yes the behavior of i20 vs i20-1 is a bit odd

@DiamondJoseph
Copy link
Contributor Author

Reveals #926 on attempting to connect- i20-1 as a beamline name is never converted to BL20J as a BeamlinePrefix("i20-1").beamline_prefix.

@DiamondJoseph
Copy link
Contributor Author

i20-1 seems to be unhappy?

bar.txt

@stan-dot stan-dot marked this pull request as ready for review January 27, 2025 13:50
@stan-dot stan-dot requested a review from a team as a code owner January 27, 2025 13:50
@stan-dot
Copy link
Contributor

stan-dot commented Feb 4, 2025

after this is merged we can deploy the latest blueapi version as 0.6.1 is misbehaving

logs-from-blueapi-in-i20-1-blueapi-0.log

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran dodal connect i20-1 and it seems happy, approved

@stan-dot stan-dot merged commit f69b1e6 into main Feb 4, 2025
18 checks passed
@stan-dot stan-dot deleted the update-i20-1 branch February 4, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants