-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move useful oav plans to dodal #589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you, one comment.
src/dodal/common/exceptions.py
Outdated
class WarningException(Exception): | ||
"""An exception used when we want to warn an external service | ||
of a problem, without necesserily halting the program altogether. | ||
For example, GDA catches this exception from Hyperion and continues with | ||
UDC""" | ||
|
||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must: I think that given this warning is UDC specific it should stay in hyperion
instead can we have like a PinNotFound
exception here then catch it in hyperion
and wrap it in the WarningException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, ta
Fixes #539
Instructions to reviewer on how to test:
Points for discussion:
WarningException
useful for anything other than Hyperion?Checks for reviewer
dodal connect ${BEAMLINE}