Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move useful oav plans to dodal #589

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Conversation

olliesilvester
Copy link
Collaborator

@olliesilvester olliesilvester commented May 30, 2024

Fixes #539

Instructions to reviewer on how to test:

  1. Confirm functionality
  2. Is the structure sensible?

Points for discussion:

  • Where is the best place to put bluesky plans which are useful to any beamline using that device?
  • Is the WarningException useful for anything other than Hyperion?

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you, one comment.

Comment on lines 1 to 7
class WarningException(Exception):
"""An exception used when we want to warn an external service
of a problem, without necesserily halting the program altogether.
For example, GDA catches this exception from Hyperion and continues with
UDC"""

pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must: I think that given this warning is UDC specific it should stay in hyperion instead can we have like a PinNotFound exception here then catch it in hyperion and wrap it in the WarningException

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, ta

@olliesilvester olliesilvester merged commit bdadd3f into main Jun 12, 2024
11 checks passed
@olliesilvester olliesilvester deleted the 539_move_setup_oav_to_dodal branch June 12, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move some setup_oav utils from hyperion to dodal
2 participants