Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draw Beam Centre on snapshot #471

Closed
DominicOram opened this issue Apr 25, 2024 · 0 comments · Fixed by DiamondLightSource/hyperion#1334 or #493
Closed

Draw Beam Centre on snapshot #471

DominicOram opened this issue Apr 25, 2024 · 0 comments · Fixed by DiamondLightSource/hyperion#1334 or #493
Assignees
@DominicOram

Comments

@DominicOram
Copy link
Contributor

For diagnostic purposes it is useful to have an idea of where the beam center is when taking a snapshot. For an initial first pass it is ok to just have a cross for the centre, rather than the full shape of the beam that GDA has.

Acceptance Criteria

  • It is possible to take a snapshot and the OAV will put the beam crosshairs on the image
  • Behavior remains unchanged for gridscan snapshots
@DominicOram DominicOram moved this to In Progress in Hyperion Apr 25, 2024
@DominicOram DominicOram self-assigned this Apr 25, 2024
@DominicOram DominicOram mentioned this issue Apr 25, 2024
Closed
DominicOram added a commit that referenced this issue Apr 25, 2024
@DominicOram
(#471) Rename snapshot to grid_snapshot
e38eeb6
DominicOram added a commit that referenced this issue Apr 25, 2024
@DominicOram
(#471) Pass params to snapshot objects and set snapshot microns based…
f088f7a 
… on these. Also move OAVConfigParams
DominicOram added a commit that referenced this issue Apr 25, 2024
@DominicOram
(#471) Add snapshot that draws beam centre crosshair
fad4c8c
DominicOram added a commit to DiamondLightSource/hyperion that referenced this issue Apr 25, 2024
@DominicOram
(DiamondLightSource/dodal#471) Rename snapshot to grid_snapshot
96bdba5
DominicOram added a commit to DiamondLightSource/hyperion that referenced this issue Apr 25, 2024
@DominicOram
(DiamondLightSource/dodal#471) Update dodal
43c8e66
This was referenced Apr 25, 2024
Closed
Merged
@DominicOram DominicOram moved this from In Progress to Review in Hyperion Apr 25, 2024
DominicOram added a commit to DiamondLightSource/hyperion that referenced this issue Apr 25, 2024
@DominicOram
(DiamondLightSource/dodal#471) Fix tests
b7a2c83
DominicOram added a commit that referenced this issue Apr 26, 2024
@DominicOram
(#471) Minor tidying up after review
d2fa37a
DominicOram added a commit that referenced this issue Apr 26, 2024
@DominicOram
(#471) MJPG no longer writes the snapshot to disk by default
47dc273
DominicOram added a commit that referenced this issue Apr 26, 2024
@DominicOram
(#471) Change crosshair to blue
ebe5cf7
DominicOram added a commit that referenced this issue Apr 26, 2024
@DominicOram
(#471) Remove excess type checking
63a1107
@DominicOram DominicOram mentioned this issue May 1, 2024
Merged
2 tasks
DominicOram added a commit that referenced this issue May 1, 2024
@DominicOram
(#471) Fix extra whitespace
d34c6bb
DominicOram added a commit that referenced this issue May 7, 2024
@DominicOram
(#471) Add docstrings
af32f10
@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DominicOram DominicOram

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
1 participant
@DominicOram