Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment update #34

Merged
merged 17 commits into from
Aug 12, 2024
Merged

Environment update #34

merged 17 commits into from
Aug 12, 2024

Conversation

tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Jul 29, 2024

  • Migrated installation settings from setup.cfg to pyproject.toml.
  • Added optional dev key when installing package to install useful packages for development use.
  • Added additional pre-commit hooks for more robust quality control; updated versions of existing hooks
    • pyproject-fmt
    • prettier
    • mypy

@tieneupin tieneupin self-assigned this Jul 29, 2024
@tieneupin tieneupin requested a review from stephen-riggs July 29, 2024 11:47
@stephen-riggs
Copy link
Contributor

stephen-riggs commented Aug 1, 2024

Things to test on this:

  • Pods can be built and deployed on kubernetes
  • Services are found by workflows
  • Wrappers can be found
  • CCPEM-pipeliner picks up the job entry point
  • Compliance of old files with new pre-commits (Fix old issues as we develop the project)

@tieneupin
Copy link
Contributor Author

Good shouts. We could revisit this next week together? I'd appreciate seeing how the various parts of the package are used.

Copy link
Contributor

@stephen-riggs stephen-riggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a merge conflict to fix but otherwise this looks good. I'll do a few tests to make sure everything is picked up ok in from the new entry point specifications

.bumpversion.cfg Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@tieneupin
Copy link
Contributor Author

It's not relevant for us at present since our packages are only run on Linux systems, but healpy is not supported for Windows (healpy/healpy#25).

.bumpversion.cfg Outdated Show resolved Hide resolved
@tieneupin tieneupin merged commit de21dcb into main Aug 12, 2024
12 checks passed
@tieneupin tieneupin deleted the env-update branch August 12, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants