Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialise sets as lists #37

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Serialise sets as lists #37

merged 1 commit into from
Feb 11, 2025

Conversation

tpoliaw
Copy link
Contributor

@tpoliaw tpoliaw commented Feb 5, 2025

The orjson library does not natively support serialising sets. Use the
default mechanism to convert any sets found in the serialisation
process into lists prior to serialisation.

@tpoliaw tpoliaw linked an issue Feb 5, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.75%. Comparing base (155a607) to head (cae5fbc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   93.65%   93.75%   +0.09%     
==========================================
  Files           6        6              
  Lines         252      256       +4     
==========================================
+ Hits          236      240       +4     
  Misses         16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The orjson library does not natively support serialising sets. Use the
`default` mechanism to convert any sets found in the serialisation
process into lists prior to serialisation.
Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpoliaw tpoliaw merged commit e242ef0 into main Feb 11, 2025
22 checks passed
@tpoliaw tpoliaw deleted the serialise_sets branch February 11, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot de/serialize documents containing sets.
2 participants