Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why WRITE_EXTERNAL_STORAGE is important? can be removed? #75

Closed
abdulmannanbutt opened this issue Apr 14, 2020 · 7 comments
Closed

why WRITE_EXTERNAL_STORAGE is important? can be removed? #75

abdulmannanbutt opened this issue Apr 14, 2020 · 7 comments
Milestone

Comments

@abdulmannanbutt
Copy link

Hi,

I hope you are doing well.

I have used your library and it is awesome.

But I want to know why you need WRITE_EXTERNAL_STORAGE permission?

Can't the library use the internal/cache storage? in one of my projects, MVAPT/security team is asking to remove this permission (coz, they think, it is not required for the application). I checked and noticed that It is being merged in the manifest due to this library.

Can you please help to see?

cc @Dhaval2404

@Dhaval2404
Copy link
Owner

@abdulmannanbutt Thank you for the feedback.

WRITE_EXTERNAL_STORAGE no longer needed when we use internal/cache storage. I'm currently working on scope storage. Which will make storage permission absolute.

So in the next version permission will be removed. Thanks

@abdulmannanbutt
Copy link
Author

abdulmannanbutt commented Apr 14, 2020

Awesome. Waiting for the next release then :) BTW, When can we expect?

@Dhaval2404
Copy link
Owner

@abdulmannanbutt I'm planing next release around the end of the month.

@Dhaval2404 Dhaval2404 added this to the v1.8 milestone Apr 14, 2020
Dhaval2404 added a commit that referenced this issue Apr 28, 2020
Added scoped storage support and removed redundant storage permission.

#29 #75
@enpboss
Copy link

enpboss commented Oct 28, 2020

How to mention internal storage in save directory?

@Dhaval2404
Copy link
Owner

@enpboss Can you please explain in detail?

Normally, This will store the image in your app-specific directory

ImagePicker.with(this)
    //Provide directory path to save images
    .saveDir(getExternalFilesDir(null)!!)
    .start()

@wonderid
Copy link

how to prevent saving the image to gallery? because I don't need to save it after choose a picture

@Dhaval2404
Copy link
Owner

@wonderid You can provide a directory to save your images. You can also delete the images after the usage if that your requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants