readCertificateInfo reports email addresses in subjectAltName field #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's an example cert file with an email address in the subjectAltName field. It's zipped because GitHub doesn't allow pem files as attachments. |
|
Would be nice to see also added documentation.
Von meinem iPhone gesendet
… Am 18.10.2017 um 06:10 schrieb Jes Sherborne ***@***.***>:
Here's an example cert file with an email address in the subjectAltName field. It's zipped because GitHub doesn't allow pem files as attachments.
***@***.***
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
So I updated the documentation. That said, I note that this section of the README is currently commented out, so it doesn't show up. When it's uncommented, my revision will show as well. |
|
I know, we working on the docs, and create the necessary changes in the source.
But it helps to create the new docs.
Von meinem iPhone gesendet
… Am 18.10.2017 um 19:15 schrieb Jes Sherborne ***@***.***>:
So I updated the documentation. That said, I note that this section of the README is currently commented out, so it doesn't show up. When it's uncommented, my revision will show as well.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Is there anything else you need from me, or is this PR ready from your perspective? |
|
It looks ready, we will merge it in a few days.
Von meinem iPhone gesendet
… Am 18.10.2017 um 21:32 schrieb Jes Sherborne ***@***.***>:
Is there anything else you need from me, or is this PR ready from your perspective?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
🎉 This PR is included in version 1.12.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A certificate's subjectAltName can include an email address in addition to IP addresses and DNS names.
This PR extends the certificate parsing to recognize any email addresses if present.
For supporting info, see the OpenSSL documentation or the relevant RFC.