Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"page-loaded" class is added to the body tag when the DOM is loaded #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mariyan-dimitrov
Copy link

No description provided.

@metodiew
Copy link
Contributor

metodiew commented Aug 6, 2019

I would keep the DX_ASSETS_VERSION unchanged, as the assets itself should be updated per project case, not for the template base theme.

The rest seems good 👏

@xavortm
Copy link
Contributor

xavortm commented Jan 20, 2020

I would say to reset the theme version change as we might change it and go with just the class name. Only thing there is that since it's a state, it's better to name it is-page-loaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants