fix(installer): resolve feature selection in Agent installer #1147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issues with feature selection in the Agent installer.
First; I created a defined "Agent" feature instead of the existing default "Complete" feature. I made this mandatory for installation; it should not be possible to install the product without installing Devolutions Agent.
Second; a treeview was used for feature selection but is horribly buggy. Clicks were often not registered, or registered as double clicks, which would cause the visual state of the checkbox to be out of sync with it's actual state 😒 This often lead me to get the wrong features installed. It's not clear if this is because of underlying .NET Framework issues (this is a notorious control) or the mitigations built on top by WixSharp).
Since a treeview is only used to support feature hierarchies - which we don't use - I swapped it for a list view control and was able to vastly simplify the logic.
Finally, I added placeholder localization for the feature information and removed some code from the Gateway installer that was not being used here. I also corrected the feature assignment of the PEDM Desktop application.