Enable device market name #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MykytaIvshkn
force-pushed
the
feature/enable_device_market_name
branch
from
1295e1f to
b56c4fc
Compare
added 2 commits
October 21, 2022 12:38
Signed-off-by: mivashkin <[email protected]>
Signed-off-by: mivashkin <[email protected]>
MykytaIvshkn
force-pushed
the
feature/enable_device_market_name
branch
from
cbbecac to
affe5f2
Compare
koral--
approved these changes
Nov 3, 2022
KostyaSha
reviewed
Jul 31, 2023
| @@ -45,7 +45,8 @@ module.exports = function EnhanceDeviceServiceFactory($filter, AppState) { | |||
| } | |||
|
|
|||
| function enhanceDevice(device) { | |||
| device.enhancedName = device.name || device.model || device.serial || 'Unknown' | |||
| device.enhancedName = device.marketName || device.name || device.model || device.serial | |||
There was a problem hiding this comment.
imho device name is the most unique setting that use can set to differentiate the same marken/model devices, could we bring device name first on list back?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR was added possibility to display correct device market name instead of "more technical" model name
An example:
