Kotlin implemtentation of minicap #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to write a minicap version in kotlin and use higher level api that should hopefully make it easier to support many os version (and the future ones). It also is likely to prevent the reccurent "Vector<> have different types" errors. The implementation is not complete and a few changes will have to be done on stf. Signed-off-by: Crepieux Pierre <[email protected]>
pcrepieux
force-pushed
the
minicap-kotlin
branch
from
1f41b35 to
09b82eb
Compare
Signed-off-by: Crepieux Pierre <[email protected]>
pcrepieux
force-pushed
the
minicap-kotlin
branch
from
dfec654 to
737733a
Compare
koral--
reviewed
Apr 12, 2021
experimental/app/build.gradle
Outdated
| implementation 'com.google.android.material:material:1.3.0' | ||
| implementation 'org.slf4j:slf4j-api:1.7.30' | ||
| implementation 'com.github.tony19:logback-android:2.0.0' | ||
| testImplementation 'junit:junit:4.+' |
There was a problem hiding this comment.
Let's remove test dependencies if we have no tests.
| putInt(screenSize.height)//Height | ||
| putInt(targetSize.width)//resized Width | ||
| putInt(targetSize.height)//resized height | ||
| put(0.toByte()) //orientation |
There was a problem hiding this comment.
maybe extract a constant for this?
There was a problem hiding this comment.
Or maybe should I simply have those sizes as parameters of sendBanner. They actually aren't used anywhere else at the moment.
| @SuppressLint("PrivateApi") | ||
| object DisplayManagerGlobal { | ||
| private var displayManager: Any? | ||
| private var CLASS: Class<*>? |
experimental/build.gradle
Outdated
| ext.kotlin_version = "1.4.31" | ||
| repositories { | ||
| google() | ||
| jcenter() |
There was a problem hiding this comment.
Jcenter will become read only in May and completely disabled next year. I would not include it.
- remove currently unused test deps and code - remove Jcenter repository - reduce scope of target and device size in MinicapClientOutput - rename CLASS to clazz Signed-off-by: Crepieux Pierre <[email protected]>
koral--
approved these changes
Apr 14, 2021
|
I am not aware about the kotlin but I will use this approach.:+1: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to write a minicap version in kotlin and
use higher level api that should hopefully make it easier
to support many os version (and the future ones).
It also is likely to prevent the reccurent "Vector<> have
different types" errors.
The implementation is not complete and a few changes will have
to be done on stf.